? Pending

User tests: Successful: Unsuccessful:

avatar frankmayer
frankmayer
13 Jun 2017

Summary of Changes

Some deprecated methods replacement

Testing Instructions

Code review only

avatar frankmayer frankmayer - open - 13 Jun 2017
avatar frankmayer frankmayer - change - 13 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jun 2017
Category Libraries
4f153d7 13 Jun 2017 avatar frankmayer CS
avatar frankmayer frankmayer - change - 13 Jun 2017
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - change - 14 Jun 2017
Title
Somme deprecated methods replacement
Some deprecated methods replacement
avatar joomla-cms-bot joomla-cms-bot - edited - 14 Jun 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Jun 2017

corrected Title.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16675.

avatar wilsonge
wilsonge - comment - 14 Jun 2017

You can't do this in 3.x - you already tried once and I explained why we couldn't :P #13164

avatar brianteeman
brianteeman - comment - 14 Jun 2017

Closed for the reason stated above

avatar brianteeman brianteeman - change - 14 Jun 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-06-14 17:04:32
Closed_By brianteeman
avatar brianteeman brianteeman - close - 14 Jun 2017
avatar frankmayer
frankmayer - comment - 14 Jun 2017

Actually this started out as a PR for setlayout() but then I saw the refreshIncludePaths(), without remembering I had done that in the past. Just an idea, it might be a good idea to remark those to not be changed, before anyone else tries to do that.

avatar wilsonge
wilsonge - comment - 14 Jun 2017

I mean setLayout still kinda suffers from the same problem as the refreshIncludePaths (although admittedly it's far less likely to be overridden)

Add a Comment

Login with GitHub to post a comment