Feeling Lucky
?
[#16673] - [Plugins/system/cache] Some improvements and cleanups in plugins/system/cache
- Fixed in Code Base
- 4 Aug 2017
- Medium
- Build: staging
- # 16673
- Diff
- frankmayer:plugins-system-cache
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Summary of Changes
Some improvements and cleanups in plugins/system/cache
- Make use of $this->app instead of JFactory::getApplication();
- Added missing docblocks
- Type-safety
Testing Instructions
- Code review
- Test site with cache enabled
Votes
# of Users Experiencing Issue
0/1
Average Importance Score
4.00
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
zero-24
- comment
- 13 Jun 2017
replace unnecessary strlen() call with simple check
I have not found that? Or I have just overlooked it?
| Labels |
Added:
?
|
||
wilsonge
- comment
- 15 Jun 2017
Looks good on review. Just want one tester for the type sensitivity thing. I think it's fine but only on quick review and don't trust myself cause a bit sleep deprived :)
andrepereiradasilva
- comment
- 23 Jun 2017
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16673.
frankmayer
- comment
- 13 Jul 2017
Can we have one more tester for this?
korneliusz401
- comment
- 4 Aug 2017
It has been tested successfully on site with cache enabled
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16673.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-04 10:38:40 |
| Closed_By | ⇒ | wilsonge |
frankmayer
- comment
- 4 Aug 2017
Thank you @korneliusz401
wilsonge
- comment
- 4 Aug 2017
Thanks @frankmayer !
As this is a system plugin please implement that a construct method that ckecks if that var is set similar to the debug plugin. As in case of an update we had issues with that as the core overwrites itself and this var maybe not set at that part of event which would result into an error.