[#16388] - [4.0] Fix com joomlaupdate
- Fixed in Code Base
- 31 May 2017
- Medium
- Build: 4.0-dev
- # 16388
- Diff
- joomdonation:fix_com_joomlaupdate
- Pending continuous-integration/drone/pr this build is pending Details
- Pending continuous-integration/appveyor/pr Waiting for AppVeyor build to complete Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16376 .
Summary of Changes
This PR fixes the issue #16376. com_cache was namespaced, so the code in JoomlaInstallerScript of com_admin needs to call the namespace class
Also, the default view in com_joomlaupdate was renamed to joomlaupdate (because Default could not be used in class name), so the the update controller in that component needs to be updated to the new view name
Testing Instructions
- Follow the issue description to see the issue
- Apply patch, confirm that the issue fixed
I already tested it myself, so maybe it could be merged by code review to save time of testers
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_joomlaupdate |
Could you please test it using my branch https://github.com/joomdonation/joomla-cms/archive/fix_com_joomlaupdate.zip ?
will test.
same Result using your Branch. Can this depend its a multilanguage Site?
No, it should not. Could you please zip the file administrator\components\com_admin\script.php and upload it here? I am thinking that the patch was not applied properly for some reason.
Nightly Build: administrator\components\com_admin[script.php.zip](https://github.com/joomla/joomla-cms/files/1041678/script.php.zip)
this is from nightly Build and applied PR:
script.php.zip
Yes. This file is valid. I don't understand why you still see the issue after that patch applied. Maybe something else which I don't know. Hope there is other tester tests this PR to confirm the error. The code is fine and I tested it myself before making the PR, too
Fine at my End, lets hope for another Tester.
The $model = new \Joomla\Component\Cache\Administrator\Model\Cache; should be correct, too (the previous code is clearly wrong)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-31 23:28:06 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I realised the reason the testing fails is because the model instance gets run after the update. so the code in this PR is never being run (we are using the code from the nightly which is still the old code). Merging this now. Then we can see once the nightly builds if things get fixed :)
Updated Installation per downloaded nightly Build update Package works.
I have tested this item? unsuccessfully on a1c10b1
same Behaviour as described in #16376
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16388.