[#16389] - [4.0] Fix default filter state in backend list views
- Fixed in Code Base
- 31 May 2017
- Medium
- Build: 4.0-dev
- # 16389
- Diff
- joomdonation:fix_filter_state_default_value
User tests: Successful: Unsuccessful:
Pull Request for Issue #16366.
Summary of Changes
This PR fix the default filter state in backend list views. It causes by the changes in PR #15455 . Now, the first time you visit the page (articles list for example), the $published value has value null instead of '' (empty string) like before, so this line return false https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_content/Model/Articles.php#L249 , no filter is applied and all articles are being shown.
This PR just cast type of $published to string to solve the issue.
Testing Instructions
-
Install Joomla 4, confirm the issue described at #16366
-
Apply patch, confirm the issue fixed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_languages com_newsfeeds com_plugins com_redirect com_tags |
Thanks Thomas
franz-wohlkoenig
- 
Working fine, but would it not be better to cast the result of getState in the actual function itself?
Like:
function getState()
{
// some code
return (string) $state;
}
Not my area, so apologies if I'm talking rubbish.
ah fair enough. thanks for the explanation
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16389.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-31 15:29:42 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 670647a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16389.