? Success

User tests: Successful: Unsuccessful:

avatar alex7r
alex7r
31 May 2017

Summary of Changes

Allow to set tinymce parameters like

$options = array(
        'inline'=>true,
        'menubar'=>false,
);
echo $editor->display( 'new_incorrect_feed', '', 500, 170, '20', '10', true, null, null, null, $options )

Testing Instructions

Pass options to the $editor, for example inline => true

Expected result

Tinymce is in inline mode.

Actual result

Tinymce is not in inline mode.

avatar alex7r alex7r - open - 31 May 2017
avatar alex7r alex7r - change - 31 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2017
Category Front End Plugins
cef3ca1 31 May 2017 avatar alex7r CS
avatar alex7r alex7r - change - 31 May 2017
Labels Added: ?
avatar alex7r
alex7r - comment - 31 May 2017

How long is it takes to pass those 2 checks Oo
It was faster earlier...

avatar brianteeman
brianteeman - comment - 31 May 2017

I am 99% certain that it was deliberate that inline mode was not supported

avatar alex7r
alex7r - comment - 31 May 2017

@brianteeman well, not only inline mode is not supported. Anything is not supported really, as only 'readonly' param is checked.
And why wouldn't you allow to use extended options, especially now, when multiple different editors is allowed at the same page, and developer also can try forcing specific editor for the field?

avatar brianteeman
brianteeman - comment - 31 May 2017

iirc inline mode will not work in joomla - but i might be remembering it completely wrong

avatar alex7r
alex7r - comment - 31 May 2017

@brianteeman Sorry, but what "iirc" stands for?
I've tested and with this PR inline mode, as well as "no menu bar" mode, is working.
More over even toolbar is managable by:
toolbar1
toolbar2
toolbar3
....
toolbarX

The only thing that might not be adjustable is that xtd buttons are placed at toolbar1

avatar mbabker
mbabker - comment - 31 May 2017
avatar alex7r
alex7r - comment - 31 May 2017

@mbabker it's kind a different thing... Everything can be made to work with some hardcode and going without Joomla. Issue is for allowing it to be used by calling Joomla editor and not some hardcoded html and script.

avatar alex7r
alex7r - comment - 19 Jun 2017

Hi everyone, will travis ever respond for this PR? Or should it be re-triggered?

avatar C-Lodder
C-Lodder - comment - 19 Jun 2017

@wilsonge could u restart?

avatar wilsonge
wilsonge - comment - 19 Jun 2017

I can't :( If there isn't a job created at all you can't restart. Sorry to be a pain but could you close and re-open this as a fresh PR to try and force it to start please?

avatar alex7r alex7r - change - 19 Jun 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-06-19 10:27:01
Closed_By alex7r
avatar alex7r alex7r - close - 19 Jun 2017

Add a Comment

Login with GitHub to post a comment