[#16386] - [4.0] Remove component sidebar from com_content
- Fixed in Code Base
- 18 Jun 2017
- Medium
- Build: 4.0-dev
- # 16386
- Diff
- ciar4n:rm-sidebar-com-content
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This component sidebar items for articles are identical to the main nav items. This PR removes the component sidebar.
Testing Instructions
Navigate through all items under 'Content' and ensure the sidebar is removed and table displaying full width. Check that other list views are uneffected.
Before
After
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_content com_fields Layout |
I figured only components where the component sidebar is identical to the main navigation. Where there is a difference (eg. com_contacts) the sidebar can remain.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16386.
So I guess we need to find out why there is a difference on the other components. Personally I think it should be avoided to have two menus there.
the only reason they are different (in core) was because we didnt insist that the sidebar was the same as the submenu.
with the new ui then that argument is mute and for contacts as an example everything in the sudebar can be moved to the menu
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16386.
It's usually the fields links that are additionally in the sidebar, but are not in the menu.
This is because those links have a conditional (can be turned off in the components options) and that doesn't work for the menuitems.
So if we drop the parameter for the fields links, we can add those links to the menu and get rid of the sidebar in most components. Or we add the possibility for menuitems with conditionals. Personally I'd prefer the first option.
This is because those links have a conditional (can be turned off in the components options) and that doesn't work for the menuitems.
check content in 3.7 - disable fields and they are gone from the menu :)
or is that because of the hardcoded nature of the content menu where as components is more dynamic
Yep, the content one is different. That's the only place where it works due to its hardcoded nature.
| Labels |
Added:
?
|
||
Conflicts fixed
| Milestone |
Added: |
||
| Milestone |
Added: |
||
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-18 14:36:17 |
| Closed_By | ⇒ | wilsonge |
Do you plan to do the rest as well like com_contact?
