Joomla! Issue Tracker | Joomla! CMS #16357 - [4.0] Replace highlighter javascript with mark.js

? ?

Closed
22 Jul 2017
Medium
Build: 4.0-dev
# 16357
Diff
dgt41:####4.0-dev-highlighter

Failure

Failure continuous-integration/drone/pr the build failed Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Failure continuous-integration/appveyor/pr AppVeyor build failed Details

User tests: Successful: Unsuccessful:

dgt41
30 May 2017

Pull Request for Issue # .

Summary of Changes

Replace Joomla's own implementation of highlighting with mark.js

Testing Instructions

Check the smart search in the front end, you should get:

Expected result

Actual result

Documentation Changes Required

df753f1 30 May 2017

init

dgt41 - open - 30 May 2017

dgt41 - change - 30 May 2017

Status

New

⇒

Pending

joomla-cms-bot - change - 30 May 2017

Category

⇒

Front End com_finder Repository Libraries JavaScript Plugins Unit Tests

brianteeman - comment - 30 May 2017

As this new script has several useful options would it be possible to add them to the plugin configuration options - i can see several of them being very useful and would address issues that have been raised in the past. especially the diacritics and case sensitive

 "exclude": [],
  "separateWordSearch": true,
  "accuracy": "partially",
  "diacritics": true,
   "synonyms": {},
   "iframes": false,
   "iframesTimeout": 5000,
   "acrossElements": true,
   "caseSensitive": false,
   "ignoreJoiners": false,
  "wildcards": "disabled",

dgt41 - comment - 30 May 2017

@brianteeman sure! will do that

brianteeman - comment - 30 May 2017

Not sure how relevant all those options are but some of them definitely are

yvesh - comment - 31 May 2017

You plan to replace the JavaScript tests you deleted? Don't you? ;-)

brianteeman - change - 8 Jun 2017

Milestone

Added:

brianteeman - change - 8 Jun 2017

Milestone

Added:

dgt41 - change - 22 Jul 2017

Status	Pending	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2017-07-22 20:04:25
Closed_By		⇒	dgt41

dgt41 - close - 22 Jul 2017

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#16357] - [4.0] Replace highlighter javascript with mark.js