? Pending

User tests: Successful: Unsuccessful:

avatar yvesh
yvesh
30 May 2017

This PR is migrating com_config to the namespaced legacy (not any more) MVC.

It's not doing a clean up on the code itself or code style etc (Which should be done independently!)

Summary of Changes

Migration to legacy MVC.

Testing Instructions

Check that com_config is still working in all places and with extensions. Also in the frontend, where it takes care on module and template editing.

Documentation Changes Required

Maybe

avatar yvesh yvesh - open - 30 May 2017
avatar yvesh yvesh - change - 30 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 May 2017
Category Administration com_config
avatar brianteeman
brianteeman - comment - 30 May 2017

and in one pr george summer of code is deleted :)

avatar mbabker
mbabker - comment - 30 May 2017

That might be a good thing ?

avatar wilsonge
wilsonge - comment - 30 May 2017

Not my summer of code project. That never went beyond a Pull Request updating a lot of this stuff. This was the year before me.

avatar laoneo
laoneo - comment - 30 May 2017

Would be nice to use the new tmpl folder for views as in #16319.

avatar yvesh yvesh - change - 30 May 2017
Labels Added: ?
avatar wilsonge
wilsonge - comment - 31 May 2017

We need to think about if we want to migrate the existing menu items over. It's a dodgy precedent to set. But potentially doable.

We want to search for index.php?option=com_config&view=config&controller=config.display.config

or

index.php?option=com_config&view=templates&controller=config.display.templates

and replace them with the new links (and this is always the non-sef path too as it's the menus table so should be ok)

avatar joomla-cms-bot joomla-cms-bot - change - 31 May 2017
Category Administration com_config SQL Administration com_admin Postgresql com_config
avatar wilsonge
wilsonge - comment - 31 May 2017

@yvesh can you please fix drone and this is good to go

avatar joomdonation
joomdonation - comment - 31 May 2017

@wilsonge Don't you want to address some issues with the code which I commented? I even haven't reviewed all the code in com_config frontend yet. Or you want to leave it to a different PR?

avatar wilsonge
wilsonge - comment - 31 May 2017

@joomdonation I think this is ok as a first pass - it definitely needs some further work - but this is 'good enough' as it is

avatar joomdonation
joomdonation - comment - 31 May 2017

@wilsonge It doesn't work yet (for frontend). So need more time for testing and debugging

avatar wilsonge wilsonge - change - 31 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-31 17:18:38
Closed_By wilsonge
avatar wilsonge wilsonge - close - 31 May 2017
avatar wilsonge wilsonge - merge - 31 May 2017

Add a Comment

Login with GitHub to post a comment