Feeling Lucky
?
[#16239] - [4.0] Searchtool.js broken when clicking on table header an option which isn't in dropdown.
- Fixed in Code Base
- 24 May 2017
- Medium
- Build: 4.0-dev
- # 16239
- Diff
- Bakual:FixSearchtools.js
User tests: Successful: Unsuccessful:
When you use SearchTools and have a table header sorting option which isn't in the sorting dropdown, it will not work in 4.0. There is a JS error Cannot read property 'length' of undefined.
This PR fixes that. @dgt41 As this is your code, can you check if the fix is correct? JS isn't my strongest area
Summary of Changes
- Checks if
desiredOptionexists before reading its property - Change \JHtmlSearchtools::main to use minified file
- Change \JHtmlSearchtools::form to use the same call as ::main (was still using deprecated call)
Testing Instructions
- Adjust the filter file (eg administrator/components/com_content/models/forms/filter_articles.xml) and remove some options from the
fullorderingfield - Make sure sorting still works in extensions using Smart Search (eg com_content)
Expected result
All header sorting options work
Actual result
Header sorting options only work if they also appear in the drodwon select.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries JavaScript |
brianteeman
- comment
- 24 May 2017
this is why relying on one person for js in j4 is a fail
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-24 11:54:10 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 24 May 2017
And that's why we're creating a javascript team ;) https://volunteers.joomla.org/teams/javascript-working-group
My fault! The code is fine!
@wilsonge please merge this!