? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
24 May 2017

Summary of Changes

The associations JS edit script needs jQuery. This pr loads jQuery in the layout itself to ensure it is always loaded. Mostly the view itself does load jQuery so nothing crashes, but when it is not the case, then a jQuery not found JS error is thrown.

Guess can be merged on review.

Testing Instructions

Edit an article on a multilingual site and change the association.

Expected result

All works as expected.

Actual result

All works as expected.

Documentation Changes Required

None.

avatar laoneo laoneo - open - 24 May 2017
avatar laoneo laoneo - change - 24 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2017
Category Layout
avatar infograf768
infograf768 - comment - 24 May 2017

would it not also be necessary for the component
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_associations/views/association/tmpl/edit.php

as the sidebyside js uses jquery ?

avatar laoneo
laoneo - comment - 24 May 2017

Guess so, didn't test it yet.

avatar infograf768 infograf768 - comment - 24 May 2017
avatar dgt41
dgt41 - comment - 24 May 2017

@infograf768 chosen is loading jQuery in that view, so no extra call needed

avatar infograf768
infograf768 - comment - 25 May 2017

😄


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16240.

avatar rdeutz rdeutz - change - 27 May 2017
Labels Added: ?
avatar wilsonge wilsonge - change - 29 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-29 09:35:47
Closed_By wilsonge
avatar wilsonge wilsonge - close - 29 May 2017
avatar wilsonge wilsonge - merge - 29 May 2017
avatar wilsonge
wilsonge - comment - 29 May 2017

Merged on review

Add a Comment

Login with GitHub to post a comment