? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
24 May 2017

Pull Request for Issue # .

Summary of Changes

We're currently 2 major versions behind on mediaelement.js, so this PR updates it to the latest version.

As it stands, there is still some jQuery behind the scenes but I won't remove that as I'm sure the new media manager will sort it.

Testing Instructions

  • Go to the Media Manager options
  • Add video/mp4 as a Legal MIME Type
  • Add mp4 as a Legal Extension
  • Upload an MP4 video (can use this sample one)
  • Click the video to play

Expected result

Video plays as expected.

avatar C-Lodder C-Lodder - open - 24 May 2017
avatar C-Lodder C-Lodder - change - 24 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2017
Category Administration com_media Repository JavaScript
avatar dgt41
dgt41 - comment - 24 May 2017

Must be a world wide disease that everyone want to move away from jQuery 🎉
Trolls please take a note of the common patterns...

avatar dgt41
dgt41 - comment - 24 May 2017

@C-Lodder we need to drop flv from the supported file formats in media manager I guess, but leave that for the other group. I'll raise an issue there.
Thanks for pulling this in!

avatar Bakual
Bakual - comment - 24 May 2017

Trolls please take a note of the common patterns...

#dgt41 You seriously should start watching your language here. Not everyone disagreeing with you is automatically a troll.

avatar laoneo
laoneo - comment - 24 May 2017

Guess this pr should be done against the media manager repo, it affects some views we don't have anymore in the new media manager.

avatar C-Lodder
C-Lodder - comment - 24 May 2017

@laoneo the changes to the PHP files aren't actually required, so do you want me to just revert them?

avatar dgt41
dgt41 - comment - 24 May 2017

@C-Lodder yes, drop the view changes here

avatar laoneo
laoneo - comment - 24 May 2017

How and where is this lib used?

avatar dgt41
dgt41 - comment - 24 May 2017

@laoneo there is no php helper to render video tags, so it's custom code

avatar laoneo
laoneo - comment - 24 May 2017

Do we use that lib in the new MM as well?

avatar dgt41
dgt41 - comment - 24 May 2017

We haven't implemented a preview for videos yet, so atm no

avatar C-Lodder C-Lodder - change - 24 May 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2017
Category Administration com_media Repository JavaScript Repository JavaScript
avatar C-Lodder
C-Lodder - comment - 24 May 2017

@dgt41 @laoneo view changes reverted

avatar wilsonge
wilsonge - comment - 27 May 2017

@laoneo You need to make a decision on this. As this is only used for rendering videos in MM, this is on you.

avatar laoneo
laoneo - comment - 28 May 2017

For me it is ok to merge. We didn't decide right now how preview is done.

avatar wilsonge wilsonge - change - 28 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-28 14:00:24
Closed_By wilsonge
avatar wilsonge wilsonge - close - 28 May 2017
avatar wilsonge wilsonge - merge - 28 May 2017

Add a Comment

Login with GitHub to post a comment