Feeling Lucky
?
[#16236] - [4.0] JError and JTableMenu aren't namespaced (yet)
- Fixed in Code Base
- 24 May 2017
- Medium
- Build: 4.0-dev
- # 16236
- Diff
- Bakual:FixSomeNonNamespaceCalls
User tests: Successful: Unsuccessful:
Joomla\CMS\Installer\Adapter\ComponentAdapter has some calls to JError and JLog which aren't marked being from "root" namespace.
Also fixing some doc blocks to \JTableMenu
Summary of Changes
Adds the leading \ to the calls.
Testing Instructions
Install or update a component and you get an error that the Error class isn't found about every second time.
Expected result
No errors or at least a message
Actual result
Fatal Error
This could be merged by review I think as the error is obvious. Pinging @laoneo for review.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
Bakual
- comment
- 24 May 2017
Done :)
wilsonge
- comment
- 24 May 2017
Does this need backporting to 3.8 where we are doing the namespace work?
laoneo
- comment
- 24 May 2017
It doesn't exist in 3.8, looks like a merge conflict.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-24 13:07:50 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
@Bakual please add
[4.0]in the title