? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
20 May 2017

Add deprecated comments

the preview view has not been used for a very very long time if ever

the select view has only been used for hathor which will not be present in j4

Pull request for #12401

avatar brianteeman brianteeman - open - 20 May 2017
avatar brianteeman brianteeman - change - 20 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2017
Category Administration com_modules
avatar brianteeman brianteeman - change - 20 May 2017
Labels Added: ?
avatar zero-24
zero-24 - comment - 20 May 2017

timme vs time?

avatar brianteeman
brianteeman - comment - 20 May 2017

typos - lol

avatar tonypartridge
tonypartridge - comment - 29 May 2017

I have tested this item successfully on 7f46eab

On code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16152.

avatar tonypartridge tonypartridge - test_item - 29 May 2017 - Tested successfully
avatar Quy
Quy - comment - 29 May 2017

I have tested this item successfully on 7f46eab

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16152.

avatar Quy Quy - test_item - 29 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 29 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 May 2017

RTC after two successful tests.

avatar wilsonge wilsonge - change - 29 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-29 22:35:47
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 29 May 2017
avatar wilsonge wilsonge - merge - 29 May 2017
avatar brianteeman
brianteeman - comment - 29 May 2017

Thanks

avatar brianteeman
brianteeman - comment - 30 May 2017

Oops this needs to be reverted - I deprecated the wrong selects

avatar brianteeman
brianteeman - comment - 30 May 2017

it should have been positions not select - mea culpa

avatar tonypartridge
tonypartridge - comment - 30 May 2017

Lol! @wilsonge please revert ?

avatar wilsonge
wilsonge - comment - 30 May 2017

Can you just do a fresh PR removing deprecated notice from the wrong view and adding to the right view?

avatar brianteeman
brianteeman - comment - 30 May 2017

will do - this afternoon - thanks

Add a Comment

Login with GitHub to post a comment