Feeling Lucky
?
?
[#16152] - Deprecate parts of com_modules
- Fixed in Code Base
- 29 May 2017
- Medium
- Build: staging
- # 16152
- Diff
- brianteeman:modules-deprecate
User tests: Successful: Unsuccessful:
Add deprecated comments
the preview view has not been used for a very very long time if ever
the select view has only been used for hathor which will not be present in j4
Pull request for #12401
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules |
| Labels |
Added:
?
|
||
brianteeman
- comment
- 20 May 2017
typos - lol
tonypartridge
- comment
- 29 May 2017
I have tested this item
On code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16152.
Quy
- comment
- 29 May 2017
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16152.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 29 May 2017
RTC after two successful tests.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-29 22:35:47 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
brianteeman
- comment
- 29 May 2017
Thanks
brianteeman
- comment
- 30 May 2017
Oops this needs to be reverted - I deprecated the wrong selects
brianteeman
- comment
- 30 May 2017
it should have been positions not select - mea culpa
wilsonge
- comment
- 30 May 2017
Can you just do a fresh PR removing deprecated notice from the wrong view and adding to the right view?
brianteeman
- comment
- 30 May 2017
will do - this afternoon - thanks
timme vs time?