? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
20 May 2017

Summary of Changes

Before this PR it was impossible to render multiple integer values, but the field allows you to select multiple integer values. This is a bug in com_fields

Testing Instructions

Create a custom integerfield
make sure Multiple = Yes
Edit content, select several integers in the custom field

Expected result

When rendered you see all the integers you selected in a comma separated string (this is what the com_fields/integer field was designed to do with multiples, Im not changing the "feature" Im fixing the bug.)

Actual result

A single integer is rendered because integer.php casts the resultant comma separated string to a (int)

After this PR a correctly rendered comma separated string is rendered

Documentation Changes Required

None

avatar PhilETaylor PhilETaylor - open - 20 May 2017
avatar PhilETaylor PhilETaylor - change - 20 May 2017
Status New Pending
avatar PhilETaylor PhilETaylor - change - 20 May 2017
Title
Allow multiple values for the integer field
[com_fields] Allow multiple values for the integer field
avatar PhilETaylor PhilETaylor - edited - 20 May 2017
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2017
Category Front End Plugins
avatar Quy
Quy - comment - 20 May 2017

Warning: implode(): Invalid arguments passed in C:\xampp\htdocs\joomla371\plugins\fields\integer\tmpl\integer.php on line 21

avatar PhilETaylor PhilETaylor - comment - 21 May 2017
avatar PhilETaylor PhilETaylor - change - 21 May 2017
Labels Added: ?
avatar PhilETaylor PhilETaylor - comment - 21 May 2017
avatar Quy
Quy - comment - 21 May 2017

I have tested this item successfully on 591bdb8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16153.

avatar Quy Quy - test_item - 21 May 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 May 2017

I have tested this item successfully on 591bdb8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16153.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 22 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 May 2017
The description was changed
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 22 May 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 22 May 2017
Easy No Yes
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 May 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 08:37:50
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017
avatar laoneo
laoneo - comment - 22 May 2017

Thanks

Add a Comment

Login with GitHub to post a comment