? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
20 May 2017

Just removing a closing slash from an img tag to make @C-Lodder a happier little boy

Ensure user provided data is correctly encoded.

avatar PhilETaylor PhilETaylor - open - 20 May 2017
avatar PhilETaylor PhilETaylor - change - 20 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 May 2017
Category Front End Plugins
avatar PhilETaylor PhilETaylor - change - 20 May 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-05-20 18:04:24
Closed_By PhilETaylor
Labels Added: ?
avatar PhilETaylor PhilETaylor - close - 20 May 2017
avatar PhilETaylor PhilETaylor - change - 20 May 2017
Status Closed New
Closed_Date 2017-05-20 18:04:24
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - change - 20 May 2017
Status New Pending
avatar PhilETaylor PhilETaylor - reopen - 20 May 2017
avatar PhilETaylor PhilETaylor - change - 20 May 2017
The description was changed
avatar PhilETaylor PhilETaylor - edited - 20 May 2017
avatar Quy Quy - test_item - 20 May 2017 - Tested successfully
avatar Quy
Quy - comment - 20 May 2017

In \plugins\fields\imagelist\tmpl\imagelist.php, directory is accounted for. Does it apply here? If yes, probably should be in a separate PR.

	if (!$path || $path == '-1')
	{
		continue;
	}

	if ($fieldParams->get('directory', '/') !== '/')
	{
		$buffer .= sprintf('<img src="images/%s/%s"%s>',
			$fieldParams->get('directory'),
			htmlentities($path, ENT_COMPAT, 'UTF-8', true),
			$class
		);
	}
	else
	{
		$buffer .= sprintf('<img src="images/%s"%s>',
			htmlentities($path, ENT_COMPAT, 'UTF-8', true),
			$class
		);
	}
avatar PhilETaylor PhilETaylor - comment - 20 May 2017
avatar Quy
Quy - comment - 20 May 2017

I have tested this item successfully on a1e0b51


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16151.

avatar Quy Quy - test_item - 20 May 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 21 May 2017

There is a lot more than just removing the slash in this PR

avatar N6REJ
N6REJ - comment - 21 May 2017

I don't see where the / is added

avatar PhilETaylor PhilETaylor - comment - 21 May 2017
avatar N6REJ
N6REJ - comment - 22 May 2017

@PhilETaylor ok, then I'm really confuzzled because then we're breaking html?

avatar PhilETaylor
PhilETaylor - comment - 22 May 2017

html doesn’t require the use of a closing slash to close void tags - a quick google will have you thinking you were mad to think it did, and back again. Its optional apparently, but there are those in the joomla world now demanding that PR creators are held to different standards than those contributing a whole new feature (com_fields) apparently.

On 22 May 2017, at 21:06, Bear notifications@github.com wrote:

@PhilETaylor https://github.com/philetaylor ok, then I'm really confuzzled because then we're breaking html?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #16151 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AAYa3LNt9sSrJs50iqqWKraLYf0GXnZ8ks5r8erPgaJpZM4NhXsD.

avatar brianteeman
brianteeman - comment - 22 May 2017

@N6REJ no we are not. html5 does not require the /

avatar N6REJ
N6REJ - comment - 22 May 2017

@PhilETaylor I think I'll go back to contemplating why the hamster spins the wheel ... thanks

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 May 2017

With and -out PR got:
bildschirmfoto 2017-05-23 um 08 03 38

System information

3.7.3-dev
Multilanguage Site
macOS Sierra, 10.12.4
Firefox 53 (64-bit)

MAMP 4.1.1

  • PHP 7.0.15
  • MySQLi 5.6.35
avatar infograf768
infograf768 - comment - 23 May 2017

@franz-wohlkoenig
This works for an imagelist custom field.
I get here OK

dl class="fields-container">
			<dd class="field-entry ">
			<span class="field-label">imagelist: </span>
<span class="field-value"><img src="/testnew/trunkgitnew/images/joomla_black.png" class="imgclass"></span>
	</dd>
</dl>

and for media

<dd class="field-entry ">
			<span class="field-label">media: </span>
<span class="field-value"><img src="/testnew/trunkgitnew/images/powered_by.png" class="mediaclass"></span>
	</dd>
avatar infograf768
infograf768 - comment - 23 May 2017

I have tested this item successfully on a1e0b51


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16151.

avatar infograf768 infograf768 - test_item - 23 May 2017 - Tested successfully
avatar PhilETaylor
PhilETaylor - comment - 23 May 2017

@franz-wohlkoenig that is impossible as there is no closing hash in the source code after the PR is applied. What I have seen though, is that Google Chrome Dev Console (and others) likes to fake the html to make it "more valid" and so sometimes adds tags. Try viewing the source code of the page using "View Source Code" features of your browser instead of using the dev tools panel.

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 May 2017

RTC after two successful tests.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 May 2017

@infograf768 didn't saw its about com_fields.

avatar rdeutz rdeutz - change - 23 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-23 19:02:16
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 23 May 2017
avatar rdeutz rdeutz - merge - 23 May 2017

Add a Comment

Login with GitHub to post a comment