User tests: Successful: Unsuccessful:
Just removing a closing slash from an img tag to make @C-Lodder a happier little boy
Ensure user provided data is correctly encoded.
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-20 18:04:24 |
Closed_By | ⇒ | PhilETaylor | |
Labels |
Added:
?
|
Status | Closed | ⇒ | New |
Closed_Date | 2017-05-20 18:04:24 | ⇒ | |
Closed_By | PhilETaylor | ⇒ |
Status | New | ⇒ | Pending |
I have tested this item
There is a lot more than just removing the slash in this PR
I don't see where the / is added
@PhilETaylor ok, then I'm really confuzzled because then we're breaking html?
html doesn’t require the use of a closing slash to close void tags - a quick google will have you thinking you were mad to think it did, and back again. Its optional apparently, but there are those in the joomla world now demanding that PR creators are held to different standards than those contributing a whole new feature (com_fields) apparently.
On 22 May 2017, at 21:06, Bear notifications@github.com wrote:
@PhilETaylor https://github.com/philetaylor ok, then I'm really confuzzled because then we're breaking html?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #16151 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AAYa3LNt9sSrJs50iqqWKraLYf0GXnZ8ks5r8erPgaJpZM4NhXsD.
@PhilETaylor I think I'll go back to contemplating why the hamster spins the wheel ... thanks
@franz-wohlkoenig
This works for an imagelist custom field.
I get here OK
dl class="fields-container">
<dd class="field-entry ">
<span class="field-label">imagelist: </span>
<span class="field-value"><img src="/testnew/trunkgitnew/images/joomla_black.png" class="imgclass"></span>
</dd>
</dl>
and for media
<dd class="field-entry ">
<span class="field-label">media: </span>
<span class="field-value"><img src="/testnew/trunkgitnew/images/powered_by.png" class="mediaclass"></span>
</dd>
I have tested this item
@franz-wohlkoenig that is impossible as there is no closing hash in the source code after the PR is applied. What I have seen though, is that Google Chrome Dev Console (and others) likes to fake the html to make it "more valid" and so sometimes adds tags. Try viewing the source code of the page using "View Source Code" features of your browser instead of using the dev tools panel.
Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
@infograf768 didn't saw its about com_fields.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-23 19:02:16 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
In
\plugins\fields\imagelist\tmpl\imagelist.php
,directory
is accounted for. Does it apply here? If yes, probably should be in a separate PR.