[#16146] - Pass required parameter to canEditState.
- Fixed in Code Base
- 5 Jul 2017
- Medium
- Build: staging
- # 16146
- Diff
- Harmageddon:missing_argument_caneditstate
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Original report by user ernebenan on joomla-bugs.de: http://www.joomla-bugs.de/forum/index.php/topic,734.0.html
Summary of Changes
The JModelAdmin::canEditState method requires one non-optional argument $record. As the parent method does not use the argument, it could be omitted, but PHP (at least starting from 7.0) throws a warning:
Warning: Missing argument 1 for JModelAdmin::canEditState(), called in /administrator/components/com_content/models/article.php on line 211 and defined in/libraries/legacy/model/admin.php on line 680
(PHP 7.0)
respectively an exception
Too few arguments to function JModelAdmin::canEditState(), 0 passed in /administrator/components/com_content/models/article.php on line 211 and exactly 1 expected
(PHP 7.1)
Testing Instructions
- Requirements:
- PHP 7.1 (to get the exception)
- Backend template: Hathor (because Isis processes the ordering request via AJAX, so you won't see the error)
- Navigate to "Content - Featured Articles".
- Order by "Ordering".
- Try to change the ordering of the articles, e.g. moving one up or down.
Expected result
- Re-ordering should work without any errors.
Actual result
- On PHP 7.1, the action fails with the previously mentioned exception.
Solution
- Apply this patch and test again.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_content |
| Status | Pending | ⇒ | Duplicate Report |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-20 15:47:13 |
| Closed_By | ⇒ | franz-wohlkoenig | |
| Rel_Number | ⇒ | 13500 | |
| Relation Type | ⇒ | Duplicate of |
closed as Duplicate Report #13500
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16146.
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/16146
If #13500 is merged before this one here, I'd agree to close this one. However, as #13500 is a bit more complex and thus might break something else, I'd like to re-open this PR here, because it fixes a bug existing in 3.7.1 and current staging.
Users with PHP 7.1 and Joomla! 3.7.0/1/upcoming 2 can't manually change the order of articles anymore. #13500 might require some more testing and in the case, that will hopefully not be happening, that it breaks something and needs to be reverted, the bug mentioned here would be re-introduced. I'd prefer to keep PRs fixing bugs separate from those improving code with no intended effect.
| Status | Duplicate Report | ⇒ | New |
| Closed_Date | 2017-05-20 15:47:13 | ⇒ | |
| Closed_By | franz-wohlkoenig | ⇒ | |
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Pending |
reopened on request of @Harmageddon
Please see this post on the Joomla 3.7.0 FAQ related to the Hathor template https://docs.joomla.org/J3.x:Hathor_admin_template_has_not_been_updated_to_work_with_the_new_features
@brianteeman understood but in 3.7.2 we have no more Hathor to select from ;-)
@brianteeman I was looking at the wrong open tab sorry for that. I can test this and post back
I have tested this item
Not sure who uses Hathor, but I tested this successfully ;)
Without applied patch, I see an "0 - An Error Has Occured"
After Patch, ordering works as expected
@pete-rossetti - Wanna do the 2nd test
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16146.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16146.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
zero-24
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-05 15:57:56 |
| Closed_By | ⇒ | rdeutz |
Duplicate #13500. Please test and mark your result here:
https://issues.joomla.org/tracker/joomla-cms/13500