[#13500] - Cleanup of canDelete, canEdit and canEditState in Component Models
- Fixed in Code Base
- 1 Jul 2019
- Medium
- Build: staging
- # 13500
- Diff
- wilsonge:canDelete
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
This cleans up canDelete, canEdit and canEditState functions so they always return a boolean and are consistent in how they operate (they can return null in many cases instead of the documented boolean). There are no actual changes to functionality here so theoretically this is code review.
But feel free to test that the authorisation checks on ability to edit, publish/unpublish and delete are unaffected
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_contact com_content com_contenthistory com_fields com_menus com_modules com_newsfeeds com_redirect com_tags Front End com_config |
| Labels |
Added:
?
|
||
| Title |
|
||||||
franz-wohlkoenig
- | Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
Done :)
It seems to me that the if (!empty($record->id)... is the wrong way around in almost every file of this PR. The first one looks correct with if (empty($record->id).
Try to delete a client from the banners component or any other item in an affected component. It fails with this PR.
@wilsonge can you look at the comments from @Harmageddon please
Fixed :) - nice spot @Harmageddon
I have tested this item
Done a code review and found this to be okay.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13500.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13500.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13500.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13500.
| Labels |
Added:
?
|
||
thx
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-01 21:12:15 |
| Closed_By | ⇒ | HLeithner |
@wilsonge please can you look at resolving the conflicts here