[#13501] - Cleanup batch copy of items
- Fixed in Code Base
- 19 Aug 2018
- Medium
- Build: staging
- # 13501
- Diff
- wilsonge:cleanup-batch-copy
User tests: Successful: Unsuccessful:
Summary of Changes
Cleanup of the batch copy'ing of data. This introduces a empty post processing of batch copied data in order for com_content to add items into the frontpage table (and other components to do whatever processing they want).
Testing Instructions
Test Banners, Newsfeeds and contact work as is (there are no changes here - they just implement the parent method which is the same)
In com_content test batch copying with items that are featured and aren't featured and ensure that items are created correctly in the #__content_frontpage table
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_contact com_content com_newsfeeds Libraries |
| Labels |
Added:
?
|
||
I have tested this item
Banner creates an error.News, Contact works fine. The entries into table #_content_frontpage are correct.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13501.
Hey both. can you please tell me what errors you are getting. I can't seem to reproduce anything at the moment (I have merged in staging since you both tested so it might be simply related to that)
See the Screenshot, i've uploaded
Hmm I definitely can't reproduce. Can you please try again on a clean copy of staging/nightly. Maybe just merging in staging now fixed something?
Reproduced it on a nightly build - same error. It's localhost with xampp on windows10 php7.0.9
Hmm I definitely can't reproduce. Can you please try again on a clean copy of staging/nightly. Maybe just merging in staging now fixed something?
@wilsonge it is about the different sql definition https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L111 for banners the title field is called name so we need a extra case for that
Umm i don't understand how I can't reproduce this cause clearly you are correct. But I guess this latest version should fix things?
I have tested this item
Everything is fine now :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13501.
Merged in staging
I have tested this item
- Tried to copy banner to another category via batch feature
- error coming up:
"Argument 1 passed to Joomla\CMS\MVC\Model\AdminModel::cleanupPostBatchCopy() must be an instance of Joomla\CMS\MVC\Model\JTableInterface, instance of BannersTableBanner given, called in
<path-to-joomla!>/Joomla_3/libraries/src/MVC/Model/AdminModel.php on line 450
<path-to-joomla!>/Joomla_3/libraries/src/MVC/Model/AdminModel.php:472"
therefore tested unsuccessful
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13501.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13501.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-19 09:58:03 |
| Closed_By | ⇒ | rdeutz |
I have tested this item
Newsfeeds and featured items are created correctly in the #__content_frontpage table
banners get an error
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13501.