? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
11 May 2017

Fix simplecolors and improve minicolors scripts of the color field, to work with the subform field

Testing Instructions

Make subform field with the color field, in the template, in templateDetails.xml somewhere here .
Example subfrom field (copy/paste to templateDetails.xml):

<field name="colors1" type="subform" label="Colors Test" multiple="true">
	<form>
		<field name="color1" type="color" label="Color1" control="simple"/>
		<field name="color2" type="color" label="Color2" />
	</form>
</field>

Expected result

The color fields in the subform should work

Documentation Changes Required

none

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar Fedik Fedik - open - 11 May 2017
avatar Fedik Fedik - change - 11 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 May 2017
Category JavaScript
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 May 2017
  • can you give Instructions where to put example Code in?
  • also what "color field works" mean? Show different colors i guess is meant?
avatar Fedik Fedik - change - 12 May 2017
The description was changed
avatar Fedik Fedik - edited - 12 May 2017
avatar Fedik
Fedik - comment - 12 May 2017

@franz-wohlkoenig I have updated the comments

also what "color field works" mean

they should work ? that all.
for type="color" there no visible difference, and for type="color" control="simple" it should work now (before it was broken)

avatar Fedik Fedik - change - 12 May 2017
The description was changed
avatar Fedik Fedik - edited - 12 May 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 May 2017

I have tested this item successfully on 12baa1b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15974.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 12 May 2017 - Tested successfully
avatar N6REJ
N6REJ - comment - 12 May 2017

I have tested this item successfully on 12baa1b

This fixes issue #15958


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15974.

avatar N6REJ N6REJ - test_item - 12 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 13 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 May 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 22 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-22 18:27:38
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 22 May 2017
avatar rdeutz rdeutz - merge - 22 May 2017

Add a Comment

Login with GitHub to post a comment