[#15973] - Add a parameter to the configuration to allow the mailto link to be switched on or off
- Fixed in Code Base
- 22 May 2017
- Medium
- Build: staging
- # 15973
- Diff
- matrikular:patch-17
User tests: Successful: Unsuccessful:
Pull Request replaces #9490
Summary of Changes
This PR allows to set the mailto link for each contact individually.
Test Instructions
- Backend: Create a contact. Give it a title and make sure to fill out the email address field. The contact doesn't have to be assigned to a user or a category. For easy access, create a menu item to that contact in a menu of your choice.
- Frontend: Verify that the email address including the mailto link is visible in the front-end. If not, please check the settings for com_contact.
- Backend: Apply the patch, go to either the component, the contact or menu settings and set "Add Mailto: Link" to "No".
- While the email address still is obfuscated, there should be no mailto: link.
Documentation Changes Required
Note: language files were changed and help screens might need to be updated.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact Language & Strings Front End |
| Labels |
Added:
?
?
|
||
@C-Lodder you're right. A developer could create an override for the JHtmlEmail::cloak method. Nevertheless, limiting the functionality of that override to a specific context can get messy quick.
An example of where this PR could be useful for non-developers as follows:
Say that you have two departments: Public Relations and a Customer Support. Both with their own representatives and individual contact forms (possible via plugin and / or custom fields). In case of the Customer Support, it is important to get the user to provide the required information, such as their customer number. Damage assessment could be another example.
One would want to guide the customer or visitor on the way he or she contacts you. That not only allows for a better, maybe even automatic processing of the request, but can also save every party a lot of time, preventing long dialogs about some missing information.
A / The mailto: link would bypass that guided path and while it is true that you could just decide not to show the email address on that very contact page, it seems a good thing to have the choice.
@matrikular where to find:
- Back-end: Go to the component settings and set "Add Mailto: Link" to "No"
At #9490 you wrote, "Add Mailto: Link" is shown after apply Patch. In this Issue (15973) you wrote to apply Patch on Step 5.
@matrikular if this PR is ready for test, please giv me a hint.
@franz-wohlkoenig thank you for your interest and pointing out the mistake in the description. As far as I'm concerned this is ready to test.
I have tested this item
Works as expected on Component, Contact and Menu.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15973.
I have tested this item
I've tested this item successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15973.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-22 18:28:23 |
| Closed_By | ⇒ | rdeutz |
@matrikular
Bug (imho):
If I display a single contact AND set "Show Contact List" to display, then mailto is always present for each contact, whatever the settings for add_mailto_link
@infograf768 thank you for reporting. I will look into it asap.
@infograf768 it seems that there is an error in the view, where the link / route to each contact in that select list is build with a double encoded ampersand. The mailto link is only one of the "visible" symptoms. If you cycle through your contacts in the select list, you will notice that the breadcrumb navigation loses its "last" element as well.
If you may: #16268
Apart from that, I've fixed a mistake I made resovling a conflict in #16264.
Would personally this were done in a JHtml override rather than adding more parameters to Joomla. But just personal preference.
Has there been much demand for this?