[#15951] - Avoid conflict between JQTooltip in the same DOM as a BSTooltip
- Fixed in Code Base
- 23 Dec 2017
- Medium
- Build: staging
- # 15951
- Diff
- PhilETaylor:issue15896ToolTips
User tests: Successful: Unsuccessful:
Pull Request for Issue Closes #15896.
Summary of Changes
Allow JQTooltip in the same DOM as a BSTooltip without JS errors when destorying tooltips in mediafield javascript
Testing Instructions
To setup:
Add this jQueryUI code to your /administrator/templates/isis/index.php before
<script src="https://code.jquery.com/ui/1.12.0/jquery-ui.min.js" integrity="sha256eGE6blurk5sHj+rmkfsGYeKyZx3M4bG+ZlFyA7Kns7E=" crossorigin="anonymous"></script>Replicate the error in the JS console
To Test:
Apply PR (leaving jQueryUI in isis/index.php)
See Error disappears
Check this works with debug OFF and debug ON in Joomla Config. (one uses minified JS and one doesnt)
Expected result
No console errors
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
I have tested this item
correction - the fix does remove the js error in the console but it still leaves other broken behaviour
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951.
with the PR and jquery-ui loaded
This PR was just to stop the javascript error and to stop the fact that all other javascript failed on the page because of that error.
If you want to fix your tooltip styles then you will need BOTH the JS and the CSS for jQuery UI loaded in your DOM. I never bothered giving the CSS before as it was not required to replicate and fix the reported issue. Nothing in this PR attempts to correctly integrate the jQueryUI, it merely seeks to prevent the conflict should a 3pd decide to add it.
Add these before the </head> in /administrator/templates/isis/index.php before you test again
<script src="https://code.jquery.com/ui/1.12.0/jquery-ui.min.js" integrity="sha256-eGE6blurk5sHj+rmkfsGYeKyZx3M4bG+ZlFyA7Kns7E=" crossorigin="anonymous"></script>
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/jqueryui/1.12.1/jquery-ui.min.css" integrity="sha256-rByPlHULObEjJ6XQxW/flG2r+22R5dKiAoef+aXWfik=" crossorigin="anonymous" />and then you will see the tooltips pretty for example:
Hello Phil,
Successfully tested.
Thank you very much for making it done (i really did not know how to create a pull request...)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951.
Hi @hikashop-nicolas, might solve #14259.
Can you test too ?
The issue is still there when you edit a HikaShop products listing menu item with HikaShop below the 3.0.1, even with that patch.
We modified the way we handle the jquery-ui on our end in the 3.0.1 version of HikaShop to circumvent the problem altogether.
| Labels |
Added:
?
|
||
This worked correctly in my Joomla 3.8.1. I am wondering why this correction is not included in the official release.
@jaimestuardo we need 2 successfully Tests before a Maintainer can decide if its gonna be merged, so please mark your Test as successfully:
- Please open Issue Tracker
- Login with your github-Account
- Click on blue "Test this"-Button above Authors-Picture
- mark your Test as successfully
- hit "submit test result"
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951.
Fix whitespace. Use tabs.
@brianteeman can you please retest?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951.
I have tested this item
It works and avoids the error message with and without debug mode.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
Thanks for Tests.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-23 16:07:38 |
| Closed_By | ⇒ | mbabker |
I have tested this item✅ successfully on 8de0ff4
replicated the error and confirmed the fix
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15951.