[#15950] - Add missing input filter to tags
- Fixed in Code Base
- 23 May 2017
- Medium
- Build: staging
- Easy Test
- # 15950
- Diff
- zero-24:inputfilter
User tests: Successful: Unsuccessful:
Summary of Changes
Missing input filter to tags. cc @dgt41
Testing Instructions
Apply this patch and confirm you can still can use the frontend tags seach
Expected result
Still works
Actual result
Works but without input filter
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
| Labels |
Added:
?
|
||
| Category | com_tags Front End | ⇒ | com_tags Front End Libraries |
does this mean that all uses of 'integer' need to be changed to 'int' ??
does this mean that all uses of 'integer' need to be changed to 'int' ??
Actually, no... https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/filter/input.php#L150-L151
Now I am more confused why it is being changed here. Guess I have lots to learn
Now I am more confused why it is being changed here. Guess I have lots to learn
I have changed it based on the doc block: https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/filter/input.php#L116 As Michael pointed we don't need to change that but we should be consistend there i think.
Installing PR failed:
System information
3.8-dev
Multilanguage Site
macOS Sierra, 10.12.4
Firefox 53 (64-bit)
MAMP 4.1.1
- PHP 7.0.15
- MySQLi 5.6.35
Then you're not on the right Joomla version. That file most assuredly exists in 3.7 (staging), with the namespacing effort it doesn't exist in 3.8.
Always test on staging unless it says it is for a different version
Thanks for Info. I updated from 3.7.3-dev cause got Message to update.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15950.
| Status | Pending | ⇒ | Ready to Commit |
| Easy | No | ⇒ | Yes |
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-23 19:13:39 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 0aa358b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15950.