[#15916] - [4.0][On Hold] Replace chosen with choices js
- Closed
- 28 Jan 2018
- Medium
- Build: 4.0-dev
- # 15916
- Diff
- dgt41:#####4.0-coices-js
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Introduce Choices.js: https://github.com/jshjohnson/Choices
- Replace chosen in the the category on the fly field
- Chosen will still be shipped (aim is that core will not use it in J4)
- Needs styling to match the templates
Testing Instructions
Edit an article and try to insert a category on the fly:
ATM there is a PHP error for Table Category not supported. File not found. So @laoneo and @joomdonation I think is related to namespacing...
Expected result
Actual result
Documentation Changes Required
UPD. This is on hold till we send a PR upstream for: jshjohnson/Choices#163
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository Administration com_categories com_content |
| Labels |
Added:
?
|
||
@joomdonation it works nicely now, thanks!
choices are not IE8 compatible...
@dgt41 So what? As long as core doesn't use it, it's no problem to include it in J3.8/9. We're not breaking B/C here. As for 3rd party extensions using it, it's up to them if they want to support IE8 or not. They don't have to support the same browsers as core does.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15916.
brianteeman
- | Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-22 20:03:57 |
| Closed_By | ⇒ | dgt41 |
| Status | Closed | ⇒ | Pending |
| Closed_Date | 2017-07-22 20:03:57 | ⇒ | |
| Closed_By | dgt41 | ⇒ |
| Title |
|
||||||
Closing here, we will try to create a custom element tag that will satisfy all our needs (accessibility, drag and drop, etc)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-28 11:33:01 |
| Closed_By | ⇒ | dgt41 |
What about deprecate in J3.8 and remove chosen with J4 but add choices into J3.8 (or 3.9) so extensions could already use it? Imho there isn't much point dragging chosen along the whole J4.
Or is there a reason you want to keep it?