? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
9 May 2017

Summary of Changes

Com_categories has a nice little feature which allows the component developer to place a form file on /administrator/components/com_foo/models/forms/category.xml which get loaded when editing a category.
This pr introduces the same functionality for com_fields. If a file is found on the location /administrator/components/com_foo/models/forms/fields/bar.xml then this file get loaded when the entity com_foo.bar is edited.

Additionally an overwrite is added which hides the "Automatic Display" field for com_users as it is not relevant for that component.

It should fix #14377 and #15244.

Testing Instructions

Create a new User custom field.

Expected result

The "Automatic Display" field in options is not displayed.

Actual result

The "Automatic Display" field in options is displayed.

Documentation Changes Required

Would be nice to have that feature documented.

avatar laoneo laoneo - open - 9 May 2017
avatar laoneo laoneo - change - 9 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 May 2017
Category Administration com_fields com_users
avatar laoneo laoneo - change - 9 May 2017
The description was changed
avatar laoneo laoneo - edited - 9 May 2017
avatar Bakual
Bakual - comment - 9 May 2017

I like this proposal, I'm only not so sure about the location where the file is placed.
With this we will have /models/forms/fields and /models/fields which may be a bit confusing.
What about following the naming patter which is used for the searchtool filters? So /models/forms/field_bar.xml?

avatar laoneo
laoneo - comment - 9 May 2017

When you have many entities, then the forms folder get cluttered with too many files. Thats why I recommend to put it into a subfolder.

avatar AlexRed
AlexRed - comment - 9 May 2017

I have tested this item successfully on bf40057

Patch ok for me. Thanks

Can do the same also for Contact field (Mail) ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15915.

avatar AlexRed AlexRed - test_item - 9 May 2017 - Tested successfully
avatar laoneo
laoneo - comment - 10 May 2017

@AlexRed I can do it, when this one got merged. It will be then only one file to add.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 May 2017

I have tested this item successfully on bf40057


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15915.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 10 May 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 10 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 May 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 10 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-10 15:08:07
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 10 May 2017
avatar rdeutz rdeutz - merge - 10 May 2017
avatar laoneo
laoneo - comment - 10 May 2017

@AlexRed check out #15953 for the Contact -> Mail fix.

Add a Comment

Login with GitHub to post a comment