avatar photodude
photodude
9 May 2017

Pull Request for Issue add some test cases with unicode chars.

Summary of Changes

adds some test cases with unicode chars (does not cover all cases just makes improvements in the test cases)

Testing Instructions

code review / unit tests pass

Documentation Changes Required

none

avatar photodude photodude - open - 9 May 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 11 May 2017
Category Unit Tests
avatar photodude
photodude - comment - 11 May 2017

@rdeutz This PR is intended to pass. These are just some base cases that currently work for multibyte characters but are not included in tests to verify that they work. Adding these will help avoid regressions.

avatar franz-wohlkoenig franz-wohlkoenig - change - 12 May 2017
Status New Discussion
avatar rdeutz
rdeutz - comment - 12 May 2017

Ok, thanks for explaining.

avatar rdeutz rdeutz - close - 12 May 2017
avatar rdeutz rdeutz - merge - 12 May 2017
avatar rdeutz rdeutz - change - 12 May 2017
Status Discussion Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-12 11:34:41
Closed_By rdeutz
avatar rdeutz
rdeutz - comment - 12 May 2017

merged on review

Add a Comment

Login with GitHub to post a comment