[#15817] - JFilterInput more === and !== cases
- Fixed in Code Base
- 22 May 2017
- Medium
- Build: staging
- # 15817
- Diff
- photodude:patch-11
User tests: Successful: Unsuccessful:
Pull Request for Issue add more === and !== cases to JfilterInput
Summary of Changes
- more === and !== cases
- make a few conditionals multiline
Testing Instructions
code review / unit tests pass
Expected result
unit tests pass
Actual result
unit tests pass
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Labels |
Added:
?
|
||
Expected result = unit tests pass
Are there any Unit tests that specifically fail if this PR is not applied? You should create some tests that fail on == but pass on === for it to be a valid test...
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15817.
@PhilETaylor none of the current unit test should fail with this. I'm not sure if there is a good way to write a unit test for this change (I'm not sure if it would even be possible).
Generally, this PR just removes some internal php type juggling on some checks. Following the general php coding practice to always preference === or ==! in checks (with some exceptions where type juggling should be allowed then use == or !=).
related PR in the framework joomla-framework/filter#23
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-22 18:39:00 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on ed6ef26
Done code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15817.