? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
4 May 2017

Pull Request for Issue #15786

Summary of Changes

Fixes the URL's for "Forgot your username" and "Forgot your password".

Also added target="_blank" so the user doesn't have to manually navigate back to the admin page after.

avatar C-Lodder C-Lodder - open - 4 May 2017
avatar C-Lodder C-Lodder - change - 4 May 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 May 2017
Category Modules Administration
avatar brianteeman
brianteeman - comment - 4 May 2017

quite right about the norel stuff - wasnt thinking straight

but please remove the target blank. it makes it bad for a11y as you cant navigate back etc

avatar C-Lodder C-Lodder - change - 4 May 2017
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 4 May 2017

sure, done

avatar brianteeman
brianteeman - comment - 4 May 2017

Thanks

avatar RonakParmar
RonakParmar - comment - 5 May 2017

After using this code in module, now the urls redirect to fronend forget password page.
Is it correct?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15816.

avatar C-Lodder
C-Lodder - comment - 5 May 2017

@RonakParmar One goes to &view=reset and the other goes to &view=remind

avatar RonakParmar
RonakParmar - comment - 5 May 2017

I have tested this item successfully on f375d36


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15816.

avatar RonakParmar RonakParmar - test_item - 5 May 2017 - Tested successfully
avatar wilsonge
wilsonge - comment - 7 May 2017

This isn't going to end up on a SEF friendly frontpage though. This is an issue we should solve as part of this PR

avatar mbabker
mbabker - comment - 7 May 2017

If you want to rewrite the router internals to be able to generate SEF URLs across applications, have at it. For now though, I don't see that as a blocker to this PR otherwise the links shouldn't have been added to the 3.x template.

avatar wilsonge
wilsonge - comment - 7 May 2017

#11060 we already have a PR for that. Have to admit I thought it had been merged though.

avatar wilsonge wilsonge - close - 8 May 2017
avatar wilsonge wilsonge - merge - 8 May 2017
avatar wilsonge wilsonge - change - 8 May 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-08 09:34:01
Closed_By wilsonge

Add a Comment

Login with GitHub to post a comment