[#15529] - Fix the path for the spinning logo ajax-loader.gif
- Closed
- 15 Jun 2017
- Medium
- Build: staging
- # 15529
- Diff
- dgt41:####core_js
User tests: Successful: Unsuccessful:
Pull Request for Issue #15305 .
Summary of Changes
Using data attributes for passing php data to javascript is totally fine (and very welcome) but in this particular occasion we need another way, since all the front end templates either need to update to echo this data attribute (not very likely to happen) or will not work.
So lets use the language strings (since what we're passing is just a word/string)...
Testing Instructions
Create a com_content custom field and edit an article from the front end.
Expected result
Actual result
no errorSpinning logo appears correctly, no error 404 not found in the browser's console
Documentation Changes Required
Nope
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Libraries JavaScript |
Open without PR an Article, Tab "Content" or Tab "Fields", got in Console/JS: Use of getAttributeNode() is deprecated. Use getAttribute() instead. jquery-migrate.min.js:2:1714
I can confirm the problem on Joomla! 3.7.2-Dev (nightly Build)
after applying the patch all i get anywhere is
Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 262144 bytes) in C:\Apache24\htdocs\cms\libraries\cms\html\html.php on line 66
Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 262144 bytes) in Unknown on line 0
Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 262144 bytes) in Unknown on line 0
Warning: Unknown: Cannot call session save handler in a recursive manner in Unknown on line 0
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Information Required |
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-15 16:55:58 |
| Closed_By | ⇒ | dgt41 |
I have tested this item? unsuccessfully on 8745f48
something in this PR is killing things like patchtester
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15529.