? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
25 Apr 2017

Pull Request for Issue #15507 .

Summary of Changes

Move message to above the list to be more consistent and add standard styling

After PR

screenshotr11-00-50

avatar brianteeman brianteeman - open - 25 Apr 2017
avatar brianteeman brianteeman - change - 25 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Apr 2017
Category Administration com_installer
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Apr 2017

I have tested this item ? unsuccessfully on 3ec3f84


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15528.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 25 Apr 2017 - Tested unsuccessfully
avatar infograf768
infograf768 - comment - 25 Apr 2017

The way this patch is done, the message would show only when there are already extensions to discover in the list and not permanently as it was designed to be.

avatar brianteeman brianteeman - change - 25 Apr 2017
Labels Added: ?
avatar infograf768
infograf768 - comment - 25 Apr 2017

imho

			<div class="alert alert-no-items alert-info">
				<?php echo JText::_('COM_INSTALLER_MSG_DISCOVER_DESCRIPTION'); ?>
			</div>

should go before
<?php if (empty($this->items)) : ?>

avatar brianteeman
brianteeman - comment - 25 Apr 2017
avatar infograf768
infograf768 - comment - 25 Apr 2017

I have tested this item successfully on 0071f43


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15528.

avatar infograf768 infograf768 - test_item - 25 Apr 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Apr 2017

I have tested this item successfully on 0071f43


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15528.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 25 Apr 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 25 Apr 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Apr 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 1 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-01 20:42:55
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 1 May 2017
avatar rdeutz rdeutz - merge - 1 May 2017
avatar brianteeman
brianteeman - comment - 1 May 2017

Thanks

Add a Comment

Login with GitHub to post a comment