[#15464] - Remove duplicate params entry and move this to the right place
- Fixed in Code Base
- 22 May 2017
- Medium
- Build: staging
- Easy Test
- # 15464
- Diff
- zero-24:com_neewsfeeds
User tests: Successful: Unsuccessful:
Pull Request for Issue #15212
Summary of Changes
Shows the hits for com_newsfeeds
Testing Instructions
Go to the setting of a neewsfeed, see the hits are now showed
Expected result
Hits are showed
Actual result
hits are not showed
Documentation Changes Required
none.
Additional info
I have not found yet a way how to fill that field with a value.
For me it looks like a did never work or copy and paste error from weblinks as also the description language key is from weblinks. This also needs to be fixed if needed at all.
I would vote for removal that from the GUI as it was nerver displayed in isis nor does it make sense nor does it work.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_newsfeeds |
Thanks. So i don't need to take care about that here. If we decide to keep that field in.
| Title |
|
||||||
| Title |
|
||||||
Correct.
"Hits" are shown, but Tooltip is about "Weblinks":
Correct this is fixed by the PR brian linked above.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15464.
| Easy | No | ⇒ | Yes |
Why is "PR-staging" removed if i set "Easy Test" on "Yes"?
Looks like there are hickups. Can you dokument the exact issue number + the exact steps you took as issue to the issue trackers issue tracker. ;)
done: joomla/jissues#962
I have tested this item
The PR does indeed display the field, but without a value.
So while the test is successful, I would recommend to either fix the display of the hits value too or remove the display of this hits field completely.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15464.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-22 22:02:08 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Sorry I highlighted its location in the wrong place. Here it is in the Weblinks plugin:
