? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
21 Apr 2017

Pull Request for Issue #15401 .

Summary of Changes

Simple fix to prevent the message Warning Error loading component: com_fields, Component not found. from showing.
It doesn't necessary fix the potential underlying issue that com_fields isn't installed

Testing Instructions

If you got that message after updating, apply this PR and the message is gone

Documentation Changes Required

None

avatar Bakual Bakual - open - 21 Apr 2017
avatar Bakual Bakual - change - 21 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Apr 2017
Category Modules Administration
avatar mbabker
mbabker - comment - 21 Apr 2017

Can you do this so JComponentHelper::isInstalled('com_fields') is only called once? JComponentHelper::isInstalled() doesn't cache results so this in effect is adding two duplicate database queries to every admin page load right now, putting it in a variable at least brings it down to one non-duplicate (at least generated by this source).

avatar zero-24
zero-24 - comment - 21 Apr 2017

In oder to fix the drone error and the comment by michael what about using: $fields = JComponentHelper::isInstalled('com_fields') && JComponentHelper::isEnabled('com_fields');

And later: if ($fields && JComponentHelper::getParams('com_users')->get('custom_fields_enable', '1')) or if ($fields && JComponentHelper::getParams('com_content')->get('custom_fields_enable', '1'))

avatar Bakual Bakual - change - 22 Apr 2017
Labels Added: ?
avatar Bakual
Bakual - comment - 22 Apr 2017

Done. I've chosen a different variable name so it's more clear.

avatar zero-24
zero-24 - comment - 22 Apr 2017

👍 Can you get that in 3.7.0 @rdeutz ?

avatar rdeutz
rdeutz - comment - 22 Apr 2017

@zero-24 did you test if it works?

avatar rjcf18 rjcf18 - test_item - 22 Apr 2017 - Tested successfully
avatar rjcf18
rjcf18 - comment - 22 Apr 2017

I have tested this item successfully on f61d85b

Seems to have fixed the message that appears after updating.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15465.

avatar zero-24 zero-24 - test_item - 22 Apr 2017 - Tested successfully
avatar zero-24
zero-24 - comment - 22 Apr 2017

I have tested this item successfully on f61d85b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15465.

avatar zero-24 zero-24 - change - 22 Apr 2017
Milestone Added:
Status Pending Ready to Commit
Labels Added: ?
avatar zero-24
zero-24 - comment - 22 Apr 2017

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15465.

avatar zero-24
zero-24 - comment - 22 Apr 2017
avatar rdeutz rdeutz - change - 23 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-23 07:56:05
Closed_By rdeutz
Labels
avatar rdeutz rdeutz - close - 23 Apr 2017
avatar rdeutz rdeutz - merge - 23 Apr 2017
avatar mcintyro
mcintyro - comment - 26 Apr 2017

I did the production upgrade to 3.7.0 from 3.6.5 and I have this warning on my admin console. The update was delivered using the Joomla Updater - I am not a developer so not sure if this issue was expected in 3.7.0 production or how to resolve it.

avatar l-arnold
l-arnold - comment - 17 May 2017

Ditto to Mcintyro above "production upgrade to 3.7.0 from 3.6.5"

Coupled with this I suspect FlexiContent is also problmatic with new com_fields behavior Basically I cannot find any "com_fields" but Joomla keeps giving the error:

Warning
Error loading component: com_fields, Component not found.

Add a Comment

Login with GitHub to post a comment