? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
21 Apr 2017

Summary of Changes

  • Rewritten all the jQuery in vanilla JS and moved the JS/CSS to separate files.
  • Also fixed up some of the Bootstrap styling.

Testing Instructions

  • apply PR
  • Go to Extensions >> Templates >> Templates
  • Ensure the tree list views are still fully functional and there are no console log errors

@dgt41 - JS ok?

avatar C-Lodder C-Lodder - open - 21 Apr 2017
avatar C-Lodder C-Lodder - change - 21 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Apr 2017
Category Administration com_templates JavaScript
avatar C-Lodder C-Lodder - change - 21 Apr 2017
The description was changed
avatar C-Lodder C-Lodder - edited - 21 Apr 2017
avatar C-Lodder C-Lodder - change - 21 Apr 2017
Labels Added: ?
avatar dgt41
dgt41 - comment - 21 Apr 2017

@C-Lodder can you rename the files to follow the pattern : [admin/site] [view name] [layout name]?
e.g. admin-templates-default.js, etc

avatar C-Lodder
C-Lodder - comment - 21 Apr 2017

@dgt41 - done and merged the JS files into 1

avatar rjcf18 rjcf18 - test_item - 21 Apr 2017 - Tested successfully
avatar rjcf18
rjcf18 - comment - 21 Apr 2017

I have tested this item successfully on b600270

Everything in the tree list views seem to be operational and no console errors were spotted in this view:
deepinscreenshot20170421173826

However an error (I'm not quite sure if it is related to these code changes) appears when I go to Extensions -> Templates -> Templates:
deepinscreenshot20170421174104

But despite that error, everything seems to be fine on the tree list views.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15449.

avatar dgt41
dgt41 - comment - 21 Apr 2017

@rjcf18 that error is unrelated to this PR, I'll do another PR for that

avatar ciar4n
ciar4n - comment - 23 Apr 2017

I have tested this item successfully on b600270


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15449.

avatar ciar4n ciar4n - test_item - 23 Apr 2017 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Apr 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Apr 2017

RTC after two successful tests.

avatar wilsonge wilsonge - change - 25 Apr 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-25 08:37:38
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 25 Apr 2017
avatar wilsonge wilsonge - merge - 25 Apr 2017

Add a Comment

Login with GitHub to post a comment