? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
21 Apr 2017

Summary of Changes

Use the getXXX methods over get with filter for input checking. cc @bembelimen

Testing Instructions

  • Apply this patch
  • make sure com_associations still work

Expected result

It still works

Actual result

It works but by using the general get method over the getXXX methods.

Documentation Changes Required

None

avatar zero-24 zero-24 - open - 21 Apr 2017
avatar zero-24 zero-24 - change - 21 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Apr 2017
Category Administration com_associations
420f664 21 Apr 2017 avatar zero-24 typo
avatar zero-24 zero-24 - change - 21 Apr 2017
Labels Added: ?
avatar zero-24
zero-24 - comment - 21 Apr 2017

Closing as this result in a performace issue (getXXX over get as the first is not a actual method) as described by @mbabker

avatar zero-24 zero-24 - change - 21 Apr 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-04-21 12:59:35
Closed_By zero-24
avatar zero-24 zero-24 - close - 21 Apr 2017
avatar mbabker
mbabker - comment - 21 Apr 2017

It's not a major performance issue. Literally the difference is getString() results in two method calls, the first of which is the magic __call() method which has to parse the arguments to get the data to call the get() method while just calling get() results in one.

Add a Comment

Login with GitHub to post a comment