Joomla! Issue Tracker | Joomla! CMS #15417 - Added email validation tests for core.js

? ?

Closed
22 Jul 2018
Medium
Build: staging
# 15417
Diff
Supun94:gsoc17_js-unit-tests

Pending

User tests: Successful: Unsuccessful:

Supun94
19 Apr 2017

Pull Request for Issue # .

Summary of Changes

This PR contains improvements of core.js JavaScript library. Adding tests for email validation.

Testing Instructions

None, only run on Travis and can test it locally.

Documentation Changes Required

None

b30da6f 19 Apr 2017

Added email validation tests for core.js

Supun94 - open - 19 Apr 2017

Supun94 - change - 19 Apr 2017

Status

New

⇒

Pending

joomla-cms-bot - change - 19 Apr 2017

Category

⇒

Unit Tests JavaScript

brianteeman - comment - 19 Apr 2017

Is this the code that is being tested
https://github.com/joomla/joomla-cms/blob/staging/media/system/js/core-uncompressed.js#L230

Its not actually used anywhere

dgt41 - comment - 19 Apr 2017

@Supun94 according to the docblock this is only used in one place in Joomla:

	/**
	 * USED IN: administrator/components/com_banners/views/client/tmpl/default.php
	 * Actually, probably not used anywhere. Can we deprecate in favor of <input type="email">?
	 *
	 * Verifies if the string is in a valid email format
	 *
	 * @param string
	 * @return boolean
	 */
	Joomla.isEmail = function( text ) {
		var regex = /^[\w.!#$%&‚Äô*+\/=?^`{|}~-]+@[a-z0-9-]+(?:\.[a-z0-9-]{2,})+$/i;
		return regex.test( text );
	};