Feeling Lucky
?
?
[#15416] - Remove empty class attribute in label tag
- Fixed in Code Base
- 1 May 2017
- Medium
- Build: staging
- Easy Test
- # 15416
- Diff
- Quy:patch-6
User tests: Successful: Unsuccessful:
Pull Request for Issue #15415.
Summary of Changes
Do not output class attribute if it is empty.
Testing Instructions
Edit an article.
View page source.
Search for class="".
None should be found in <label> tag.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Easy | No | ⇒ | Yes |
brianteeman
- comment
- 19 Apr 2017
This works but i think it is wrong (or exposing another bug). There is an option for the field to apply an edit class and i "think" that is supposed to be displayed here but its not
Quy
- comment
- 19 Apr 2017
Edit Class pertains to the fields and not to the labels. Here is an example where I added editClassHere to Edit Class:
<div class="controls"><input type="text" name="jform[com_fields][text]" id="jform_com_fields_text" value="" class="editClassHere required" required aria-required="true" /></div>
brianteeman
- comment
- 19 Apr 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15416.
brianteeman
- comment
- 19 Apr 2017
Sorry @quy you were correct I was looking at the wrong place. All good!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15416.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 19 Apr 2017
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-01 20:15:12 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on 5bf6c6d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15416.