I have tested this item ✅ successfully on e3fe25c

I have tested this item 🔴 unsuccessfully on e3fe25c

Without PR:

With PR:

@franz-wohlkoenig are the images in the correct order?

@dgt41 Yes, applied PR having 4 Tabs instead 2 Tabs without PR.

There was an bug with the tab titles. @franz-wohlkoenig can you check that is ok now?

4 Tabs:

There was an bug with the tab titles.

@dgt41 Actually, the bug is that the tabs are doubled, the missing translated title wasn't the real bug 😄

Hmmm, I get 2 tabs here

@dgt41 would it help to install fresh?

Maybe, I still can't figure out why these tabs are bouble

Fresh Install (staging), same Result:

Fresh Install (staging), same Result:

staging means 3.7? i guess you mean 4.0-dev? ;)

Brand new install, fresh db, still can't replicate this (FF):

@franz-wohlkoenig this is for J4, so @zero-24 is right!

@zero-24 is right, i meant 4.0-dev.

Let me get a fresh installation from this again to verify this.

Weird, no tabs appear at all for me O.o

@rjcf18 are you getting any errors in the browsers console?

I've edited the comment, you can see the error in the previous comment.

In FF-Console CSS:
Expected media feature name but found '-webkit-min-device-pixel-ratio'. template.min.css:1:359
Expected colour but found 'auto'. Expected colour but found '-webkit-focus-ring-color'. Expected end of value but found '-webkit-focus-ring-color'. Error in parsing value for 'outline'. Declaration dropped. template.min.css:1:449
Error in parsing value for '-webkit-text-size-adjust'. Declaration dropped. template.min.css:6:175
Unknown pseudo-class or pseudo-element '-webkit-inner-spin-button'. Ruleset ignored due to bad selector. template.min.css:6:1928
Unknown pseudo-class or pseudo-element '-webkit-search-cancel-button'. Ruleset ignored due to bad selector. template.min.css:6:2085
Unknown pseudo-class or pseudo-element '-webkit-file-upload-button'. Ruleset ignored due to bad selector. template.min.css:6:2181
Unknown property 'orphans'. Declaration dropped. template.min.css:6:2862
Unknown property 'widows'. Declaration dropped. template.min.css:6:2871
Expected colour but found 'auto'. Expected colour but found '-webkit-focus-ring-color'. Expected end of value but found '-webkit-focus-ring-color'. Error in parsing value for 'outline'. Declaration dropped. template.min.css:6:4641
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:8643
Unknown pseudo-class or pseudo-element '-ms-expand'. Ruleset ignored due to bad selector. template.min.css:6:24921
Unknown pseudo-class or pseudo-element '-webkit-input-placeholder'. Ruleset ignored due to bad selector. template.min.css:6:25072
Unknown pseudo-class or pseudo-element '-ms-input-placeholder'. Ruleset ignored due to bad selector. template.min.css:6:25136
Unknown pseudo-class or pseudo-element '-ms-value'. Ruleset ignored due to bad selector. template.min.css:6:25459
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:30190
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:30386
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:30545
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:30978
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:31307
Unknown property 'user-select'. Declaration dropped. template.min.css:6:31809
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:40974
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:41652
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:43038
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:44475
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:44804
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:47625
Unknown property 'user-select'. Declaration dropped. template.min.css:6:48468
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:49533
Unknown pseudo-class or pseudo-element '-ms-value'. Ruleset ignored due to bad selector. template.min.css:6:50320
Unknown pseudo-class or pseudo-element '-ms-expand'. Ruleset ignored due to bad selector. template.min.css:6:50464
Unknown property 'user-select'. Declaration dropped. template.min.css:6:50987
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:51455
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:52669
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:52993
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:54268
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:54416
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:55055
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:55206
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:55848
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:55999
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:56643
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:56794
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:57385
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:57536
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:59839
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:63072
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:63164
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:63417
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:64976
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:68715
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:69230
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:69349
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:69817
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:74573
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:74939
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:75244
Unknown property 'line-break'. Declaration dropped. template.min.css:6:75893
Unknown property 'line-break'. Declaration dropped. template.min.css:6:77732
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:81486
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:82271
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:83387
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:86082
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:86150
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:86493
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:86564
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:86908
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:86979
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:87323
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:87394
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:87739
Error in parsing value for 'display'. Declaration dropped. template.min.css:6:87810
Error in parsing value for 'position'. Declaration dropped. template.min.css:6:102802
Unknown property 'speak'. Declaration dropped. template.min.css:9:33914
Unknown property 'user-select'. Declaration dropped. template.min.css:9:34216
Error in parsing value for 'min-width'. Declaration dropped. template.min.css:9:36180
Error in parsing value for 'transition-delay'. Declaration dropped. template.min.css:9:45485
Error in parsing value for 'transition-delay'. Declaration dropped. template.min.css:9:48404

@franz-wohlkoenig the CSS warnings/errors are not related to this PR

No idea how on earth you're getting all these CSS errors. What version of FF are you using? And do you have any experimental features enabled?

On firefox the same happens:

@dgt41 CSS was the only Part with Errors.

@C-Lodder Firefox 53.0 (64-bit), as i know i have no experimental Features enabled, only something like dict.cc

@rjcf18 can you check once more, thanks!

Did another fresh installation, and I'm still having the same problem:

Oh wait wait sry, give me a minute let me try something

The HEAD was still at the previous commit :P sry about that. But still the same problem though:

are you using the browser in responsive mode?
I'm trying to figure out why I don't get this

I've tried both without and with responsive mode and have tried in Google chrome (56.0.2924.76 (64-bit)) and Firefox (48.0).

Still can't replicate this and without the ability to replicate it I can't fix it.
By the way are the tabs in the other views (e.g. article edit) working correctly?

@dgt41

In every other view I can see that they are working properly (buttons, accordeons, tabs, etc), I get that same error in the menu item type selection modal window despite it working well:

But I can't quite replicate what happens to @franz-wohlkoenig the tabs don't repeat for me:

@franz-wohlkoenig I really don't know how you end up with double tabs, the code runs only once!
Ah, maybe the patch tester didn't delete some files?
Are you using git or patch tester here?

@rjcf18 same question are you using patch tester or git here?

I'm using git (git clone --depth 1 -b 006-clean-up-bootstrap --single-branch https://github.com/dgt41/joomla-cms.git) and for each of your commit I clone and install everything from scratch so I can be sure I have a 100% clean installation and that there are no problems with remainders from previous versions of some files.

@dgt41 i use Patchtester. Will reinstall it.

Issue stay same after reinstalling Patchtester; same in Chrome 57, Safari 10.1.

@franz-wohlkoenig I'm afraid this PR cannot be tested with patchtester

@dgt41 okay. Possible to write this in future Test instructions?

@franz-wohlkoenig I think there is a known limitation for patch tester some files, @mbabker can explain the issue better

@dgt41 theres also a Comment that Patchtester in J4 is experimental – but most works. I thought you know that this PR isn't testable by Patchtester and so to write info.

Unless something changed with GitHub this PR is fine with patch tester. The biggest problems relate to binary files, none of the files changed here fall into that category.

The patch tester quirk is it does not patch files. It does a full replace based on the file from the remote branch. So if that is in any way out of sync with the base branch, it can cause problems.

@franz-wohlkoenig honestly I didn't even think about patchtester in the first place. Till J4 repo become public all the participants were using git.

Please also check that you browser cache is cleared before testing. Not that it caches some parts of the JS.
When using Chrome, a good way to have cache always cleared is to have the development tools open (F12) and have "Disable cache (while DevTools is open)" enabled in its settings.

Yep I was aware of that option and have it activated, plus I clear the cache anyways just in case both in chrome and firefox. For this case I guess the problem isn't related to that, but yeah it's a good practice.

@Bakual thanks, should be fine now

I have tested this item ✅ successfully on 1d60931

The problem seems to be solved, no longer getting the error on the console on the modal window and the tabs in Joomla! Update seem to be displayed correctly and with no errors:

I have tested this item 🔴 unsuccessfully on 1d60931

Test on fresh Install 4.0.0-dev, double Tabs Issue stay:

@franz-wohlkoenig I think patchetester is not behaving with this issue

I have tested this item ✅ successfully on 1d60931

RTC after two successful tests.