Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
18 Apr 2017

Pull Request for Issue #15369 .

Summary of Changes

This PR proposes to remove the "disabled" and "readonly" from the fields parameters as they don't make any sense for a field.

Testing Instructions

  • Create a new field or save an existing one again so the readonly/disabled parameters aren't stored anymore.
  • Test that the field works as expected.
  • Test especially also that ACL restrictions still work, eg a user which isn't allowed to edit a value has a readonly/disabeld field.

Documentation Changes Required

Maybe if documentation is already written with those parameters mentioned.

avatar Bakual Bakual - open - 18 Apr 2017
avatar Bakual Bakual - change - 18 Apr 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Apr 2017
Category Administration com_fields Language & Strings
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 18 Apr 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Apr 2017

I have tested this item successfully on 115a27d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15373.

avatar franz-wohlkoenig franz-wohlkoenig - change - 18 Apr 2017
Easy No Yes
avatar brianteeman
brianteeman - comment - 18 Apr 2017

Note to whoever merges. If this is merged for 3.7.0 (which it should) then its fine but if it waits until 3.7.1 then the language strings will have to be kept until 4.0 :(

avatar rdeutz rdeutz - change - 18 Apr 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-04-18 13:23:26
Closed_By rdeutz
avatar rdeutz rdeutz - close - 18 Apr 2017
avatar rdeutz rdeutz - merge - 18 Apr 2017

Add a Comment

Login with GitHub to post a comment