cant this be done in 3.x

On 27 March 2017 at 21:51, Dimitri Grammatikogianni <
notifications@github.com> wrote:

Pull Request for Issue # .
Summary of Changes

• Eliminate inline scripts
• Drop some useless jQuery dependencies
• Use .min.js (can someone do this as well in 3.x, this is not 2006)

Testing Instructions

Associations still work as before
Expected result Actual result Documentation Changes Required

You can view, comment on, or merge this pull request online at:

#14945
Commit Summary

• com_associations

File Changes

• M administrator/components/com_associations/models/fields/
  modalassociation.php
  https://github.com/joomla/joomla-cms/pull/14945/files#diff-0 (16)
• M administrator/components/com_associations/views/
  associations/tmpl/default.php
  https://github.com/joomla/joomla-cms/pull/14945/files#diff-1 (24)
• M administrator/components/com_associations/views/
  associations/tmpl/modal.php
  https://github.com/joomla/joomla-cms/pull/14945/files#diff-2 (13)
• A media/com_associations/js/admin-associations-default.js
  https://github.com/joomla/joomla-cms/pull/14945/files#diff-3 (22)
• A media/com_associations/js/admin-associations-default.min.js
  https://github.com/joomla/joomla-cms/pull/14945/files#diff-4 (1)
• A media/com_associations/js/admin-associations-modal.js
  https://github.com/joomla/joomla-cms/pull/14945/files#diff-5 (19)
• A media/com_associations/js/admin-associations-modal.min.js
  https://github.com/joomla/joomla-cms/pull/14945/files#diff-6 (1)
• A media/com_associations/js/modal-associations.js
  https://github.com/joomla/joomla-cms/pull/14945/files#diff-7 (17)
• A media/com_associations/js/modal-associations.min.js
  https://github.com/joomla/joomla-cms/pull/14945/files#diff-8 (1)
• D media/com_associations/js/sidebyside-uncompressed.js
  https://github.com/joomla/joomla-cms/pull/14945/files#diff-9 (303)
• D media/com_associations/js/sidebyside-uncompressed.min.js
  https://github.com/joomla/joomla-cms/pull/14945/files#diff-10 (1)
• M media/com_associations/js/sidebyside.js
  https://github.com/joomla/joomla-cms/pull/14945/files#diff-11 (304)
• M media/com_associations/js/sidebyside.min.js
  https://github.com/joomla/joomla-cms/pull/14945/files#diff-12 (2)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/14945.patch
• https://github.com/joomla/joomla-cms/pull/14945.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#14945, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8aDGdRJ8xLUl1WdqlhRu9ySiLYxJks5rqCFkgaJpZM4MqzyM
.

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@brianteeman it won't look good due to IE8

The issue is that we can't test it as one can't install a language in 4.0

Tried to test as we can now install language packs. Got a 500
#15329

@dgt41 you need to fix conflicts here please

@wilsonge conflicts resolved!