[#14703] - UX - Misleading delete button text
- Closed
- 27 May 2017
- Medium
- Build: staging
- # 14703
The JToolbarHelper::deleteList method uses as default text the JTOOLBAR_DELETE language key.
The language key JTOOLBAR_DELETE is translated as "Delete".
In core components the language key used for deleteList buttons is JTOOLBAR_EMPTY_TRASH.
The language key JTOOLBAR_EMPTY_TRASH is translated as "Empty trash".
As a non-native English speaker, I think "Empty trash" is misleading.
It sounds to me like "permanently delete all items from the trash".
And that's not what the button actually do.
The button allows the user to delete selected items, so why don't we use the default "Delete" text?
| Labels |
Added:
?
|
||
I think that the difference between items that can be trashed and items that can't be trashed is already clear.
For items that can be trashed, there is another button and is the "Trash" button (JToolbarHelper::trash).
The JToolbarHelper::trash method uses the JTOOLBAR_TRASH language key.
The language key JTOOLBAR_TRASH is translated as "Trash".
In core components the default behaviour in list views is to display only published and unpublished items (archived and trashed items are generally hidden).
If the state filter is set to "trashed" the list view displays the trashed items and the "Empty trash" button in the toolbar. Once an item has been trashed, can be permanently deleted.
What the "Empty trash" does is exactly what the "Delete" button does: permanently deletes an item or a list of items. It does not empty the "trash bin".
For this reason I assume they can have the same text.
| Category | ⇒ | UI/UX |
| Category | UI/UX | ⇒ | Templates (admin) UI/UX |
| Status | New | ⇒ | Discussion |
For this one can we have the same text or a change is required?
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-27 04:04:22 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_Date | 2017-05-27 04:04:22 | ⇒ | 2017-05-27 04:04:23 |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/14703
closed as having PR #14954
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14703.
As far as I know we do have a difference.
We use
JTOOLBAR_DELETEwhen there is no trash for the items i.e. deleting directly.Example:
administrator/index.php?option=com_installer&view=updatesitesor
administrator/index.php?option=com_languages&view=overrides