[#14702] - a11y icons in layouts
- Fixed in Code Base
- 24 May 2017
- Medium
- Build: staging
- # 14702
- Diff
- brianteeman:ally-layouts
User tests: Successful: 2 Quy, tonypartridge Unsuccessful: 0
When reading our default markup for rendering icons, assisistive technology may have the following problems.
The assistive technology will not find any content to read out to a user
The assistive technology will read the unicode equivalent, which does not match up to what the icon means in context, or worse is just plain confusing. In our use case it is always plain wrong. For example the unicode character used to display the trashed icon is \4c which is equal to L
When an icon is not an interactive element the simplest way to provide a text alternative is to use the aria-hidden="true" attribute on the icon and to include the text with an additional element, such as a < span>, with appropriate CSS to visually hide the element while keeping it accessible to assistive technologies.
In this case we have the text and it is displayed so we just need to add the aria-hidden to prevent the icon being "read aloud"
This PR should address all the remaining icons in the layouts folder where we do have text
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
?
|
||
| Category | Layout | ⇒ | Layout Unit Tests |
| Category | Layout Unit Tests | ⇒ | Accessibility Layout Unit Tests |
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14702.
I have tested this item
Code Review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14702.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-24 20:05:30 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Thanks
I updated the unit test - it passes so I hope I made the change correctly