? Pending

User tests: Successful: 2 Quy, tonypartridge Unsuccessful: 0

avatar brianteeman
brianteeman
17 Mar 2017

When reading our default markup for rendering icons, assisistive technology may have the following problems.

The assistive technology will not find any content to read out to a user
The assistive technology will read the unicode equivalent, which does not match up to what the icon means in context, or worse is just plain confusing. In our use case it is always plain wrong. For example the unicode character used to display the trashed icon is \4c which is equal to L

When an icon is not an interactive element the simplest way to provide a text alternative is to use the aria-hidden="true" attribute on the icon and to include the text with an additional element, such as a < span>, with appropriate CSS to visually hide the element while keeping it accessible to assistive technologies.

In this case we have the text and it is displayed so we just need to add the aria-hidden to prevent the icon being "read aloud"

This PR should address all the remaining icons in the templates folder where we do have text

avatar brianteeman brianteeman - open - 17 Mar 2017
avatar brianteeman brianteeman - change - 17 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Mar 2017
Category Front End Templates (site)
avatar brianteeman
brianteeman - comment - 19 Mar 2017

No idea why this failed appveyor test. looks like an issue with appveyor not this pr

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Apr 2017
Category Front End Templates (site) Accessibility Front End Templates (site)
avatar photodude
photodude - comment - 17 Apr 2017

@mbabker looks like appveyor needs to be rerun here. (looks like the SQLSRV module has an intermitant download connection failure)

avatar Quy Quy - test_item - 19 Apr 2017 - Tested successfully
avatar Quy
Quy - comment - 19 Apr 2017

I have tested this item successfully on 15ada2c

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14704.

avatar tonypartridge
tonypartridge - comment - 23 May 2017

@mbabker can you please re-run drone?

avatar tonypartridge
tonypartridge - comment - 23 May 2017

I have tested this item successfully on 15ada2c

Code Review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14704.

avatar tonypartridge tonypartridge - test_item - 23 May 2017 - Tested successfully
avatar zero-24
zero-24 - comment - 23 May 2017

Drone did rerun and is happy now

avatar franz-wohlkoenig franz-wohlkoenig - change - 24 May 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 May 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 24 May 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-05-24 20:06:12
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 24 May 2017
avatar rdeutz rdeutz - merge - 24 May 2017
avatar brianteeman
brianteeman - comment - 24 May 2017

Thanks

Add a Comment

Login with GitHub to post a comment