[#14633] - [Multilanguage] Normalising Hathor Associations fielset label
- Fixed in Code Base
- 15 Mar 2017
- Medium
- Build: staging
- # 14633
- Diff
- infograf768:normalising_assoc_fieldset
User tests: Successful: 2 alikon, franz-wohlkoenig Unsuccessful: 0
Pull Request for discussion in #14623
Summary of Changes
Hathor will now use the Global language string already used in Isis for its Associations slider
Descriptions for these fieldsets were no more used for a while. Modified code.
Related language strings are marked as deprecated
Testing Instructions
Set a multilingual site with associations.
Set Hathor as your default template.
Edit or create an article
Edit or create a category
Edit or create a contact
Edit or create a Newsfeed
Edit or create a menu item
Expected result
before patch one will get
After patch
The other changes in code just have to be reviewed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_contact com_content com_menus com_newsfeeds Language & Strings Templates (admin) |
@brianteeman
Please test.
please kill hator asap
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14633.
is for lack of PR or for b/c ?
b/c - sadly
PR looks ok to me on review
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avg.com
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
On 15 March 2017 at 17:43, Nicola Galgano notifications@github.com wrote:
is for lack of PR or for b/c ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#14633 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bmmmDsKJDXNbFIocDGd2SRfGFnDks5rmCNGgaJpZM4Mdtyv
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
RTC. Thanks for testing.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14633.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14633.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-15 20:23:56 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
?
?
|
||
I have tested this item✅ successfully on d20aff2
In all 5 Types Slider-Name is
Associations.This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14633.