? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
15 Mar 2017

As discussed #14614 this PR comments out the debug mode

###Test Instructions
Before PR you have a tab called Advanced in the System-Joomla statistics plugin
After PR you dont have the tab

avatar brianteeman brianteeman - open - 15 Mar 2017
avatar brianteeman brianteeman - change - 15 Mar 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Mar 2017
Category Front End Plugins
avatar zero-24
zero-24 - comment - 15 Mar 2017

I think we should remove that instead of just comment the code out.

avatar zero-24
zero-24 - comment - 15 Mar 2017

If we need a debug option lets implement a constant you can change in the plugin code if you need to debug.

avatar brianteeman
brianteeman - comment - 15 Mar 2017

PR welcome ;)

Personally I would have just deleted it completely

http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
Virus-free.
www.avg.com
http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On 15 March 2017 at 10:59, zero-24 notifications@github.com wrote:

If we need a debug option lets implement a constant you can change in the
plugin code if you need to debug.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#14634 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RzU_RHvxbhmkvC5NBfukkIcxSbaks5rl8SFgaJpZM4Mdxc-
.

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 8 Apr 2017

closed in favour of #15178

avatar brianteeman brianteeman - change - 8 Apr 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-04-08 11:02:15
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 8 Apr 2017
avatar zero-24
zero-24 - comment - 8 Apr 2017

Sorry that it took that long :( see here: #15178 @brianteeman

Add a Comment

Login with GitHub to post a comment