Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#14632] - Fixed Strip whitespace from Json string before decoding (joomla-cms/libraries/vendor/joomla/registry/src/Format/Json.php)

? ? Pending

User tests: Successful: 0 Unsuccessful: 0

avatar Bhola-B2C
Bhola-B2C
15 Mar 2017

Pull Request for Issue #14502 .

Summary of Changes

Beside using trim, I also used preg_replace() to remove any whitespaces in between the JSON string.

Testing Instructions

Code Review

Expected result

Actual result

Documentation Changes Required

None

avatar Bhola-B2C Bhola-B2C - open - 15 Mar 2017
avatar Bhola-B2C Bhola-B2C - change - 15 Mar 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 15 Mar 2017
Category ⇒ External Library Libraries
avatar Bhola-B2C Bhola-B2C - change - 15 Mar 2017
The description was changed
avatar Bhola-B2C Bhola-B2C - edited - 15 Mar 2017
avatar mbabker
mbabker - comment - 15 Mar 2017

? as explained in the other issue it is not this formatter's responsibility to "clean" the data it receives. The outer trim is a sanity check but anything happening to the actual data is invalid and potentially breaks the fallback onto the INI format used if the basic JSON checks are not met.

avatar Bhola-B2C
Bhola-B2C - comment - 15 Mar 2017

Then what should be done

avatar Bhola-B2C
Bhola-B2C - comment - 15 Mar 2017

We need to strip all the whitespaces from Json string?

avatar Bhola-B2C
Bhola-B2C - comment - 15 Mar 2017

I'm not able to understand..explain it clearly plz

avatar rdeutz rdeutz - change - 27 May 2017
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 18 Aug 2017
Category External Library Libraries ⇒ External Library Libraries Composer Change
avatar brianteeman
brianteeman - comment - 18 Aug 2017

Closed for the reason stated above by @mbabker

avatar brianteeman brianteeman - change - 18 Aug 2017
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-08-18 21:04:51
Closed_By ⇒ brianteeman
avatar brianteeman brianteeman - close - 18 Aug 2017

Add a Comment

Login with GitHub to post a comment