[#14484] - [New Calendar] Replacing "Time" by the clock icon
- Fixed in Code Base
- 12 Mar 2017
- Medium
- Build: staging
- # 14484
- Diff
- infograf768:clock
User tests: Successful: Unsuccessful:
Pull Request for Issue #14422 (comment)
In some languages, the word "Time" is too long to fit
Summary of Changes
Changing the "Time" string to the clock icon
Testing Instructions
Patch, make sure to clear cache, display the Calendar.
You should get
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
I've tested this item successfully for the icon-clock.
What do you think about setting the btn-group centered? Or should this be another issue?
@chmst can you please mark your test at Issue-Tracker as successfully?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14484.
done ;)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14484.
What do you think about setting the btn-group centered? Or should this be another issue?
No idea what you mean.
| Status | Pending | ⇒ | Ready to Commit |
3 good tests.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14484.
thanks @chmst
@infograf768 i think @chmst means to center the group (clock+Hour+Minute)
It is not a btn-group and one should not forget we also mau have am-pm
What do you think about setting the btn-group centered
Do we have a centered class in bs2?
Doesnt this code require you to be loading icomoon?
While that is almost certainly true for the admin as both core templates use it is not the same for the front end where this will also be displayed
Also for accessibility purposes when using icons in this way you should be using aria-hidden="true" to hide the icon as it is used purely for decoration.
Indeed, we do have an issue in Beez, and not only for the clock (See buttons at bottom:
Taking off RTC.
| Status | Ready to Commit | ⇒ | Pending |
back to pending
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14484.
As my comment has highlighted a bigger issue with none protostar templates and the entire calendar field this should probably get a release blocker status
Can be fixed in the calendar.css, copy paste the basic btn class from BS, and for icon-time class have an inline base64 image
That would work and would be template independent
Will update here to get an inline base64 image.
As for the BS btn-goup, I would not know which ones to pick.
| Labels |
Added:
?
|
||
Modified PR to use base64 image.
We should now get:
Please test that one.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14484.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14484.
| Status | Pending | ⇒ | Ready to Commit |
RTC
Thanks @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14484.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-12 16:29:47 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 97b5e71
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14484.