[#14422] - Calendar various fixes
- Fixed in Code Base
- 9 Mar 2017
- Medium
- Build: staging
- # 14422
- Diff
- dgt41:cal_more_fixes
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- CS
- Fix the submit binding to work for Persian calendar (basically for all calendars)
- Refactor the buttons on the bottom so they're not part of the table for easier customisation/styling
Testing Instructions
Apply the patch and play with the calendar, everything should still work
@infograf768 @coolcat-creations @ghasemy50 please test!
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Labels |
Added:
?
|
||
Buttons: clear just clears the input and today sets the input to today, so only close does close the calendar!
Do you have any error on you console?
Click on another Day: TypeError: a.srcElement is undefined
@franz-wohlkoenig should be fine now...
I have tested this item
Test on Articles-Published and Field-Caöendar.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14422.
hi,
it's ok.
just in persian language ,'fa-ir.js' file in \media\system\js\fields\calendar-locales have a bad translate.
exit parameter is translated to 'ستن' , good translate is 'بستن'. please solve it thank you.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14422.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14422.
@ghasemy50
See #14428 for the calendar-locale correction
I have tested this item
German string is still cut off - but Design improved once more.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14422.
@coolcat-creations do you mean the time sting? This is part of the table and thus got less space
@coolcat-creations
Could German use "Zeit" instead ?
We do have 'very' limited space there.
@infograf768 yes German could. But: what for croatian "Vrijeme", greek χρόνος, Vietnamese:Thời gian ?
Why do we have limited space? There is whitespace right of the time dropdowns.
I'm sure that could be solved.
I suggest an icon clock.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14422.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-09 13:38:55 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Given this is better, i'm going to merge this now and let's keep incrementing :)
The AM/PM will display when calendar field contains
timeformat="12"
+1 then for changing the string into a clock icon and
+1 for adding timeformat parameter into the custom field
+1 for adding timeformat parameter into the custom field
Depends a bit if that is more a language specific thing. eg if in UK they prefer 24hr and in Germany 12hr it would make more sense to put that setting into the language pack.
the important to consider is not in the calendar imho, but the resulting display. the strings already exist in the core packs. adding a A after the hour will display am/pm
Example:
DATE_FORMAT_LC3="j F Y H:i:s A"
By changing
cell.innerHTML = JoomlaCalLocale.time || " ";
to
cell.innerHTML = "<span class='icon-clock'> </span>";
I can get a clock
What do you think? This would indeed solve that issue.
(I would not touch at the time parameter in the code and locale and just leave it there as is. Just change the display to the clock)
Article, Tab "Publishing", "Start Publishing": Click on a new Date got no Reaction, also on Buttons on Bottom no Reactopn after Click on them (only on "Close" is Reaction).