[#14423] - [postgresql] - remove notice from manage database
- Closed
- 2 Nov 2017
- Medium
- Build: staging
- # 14423
- Diff
- alikon:patch-85
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #14331 .
Summary of Changes
managed DROP DEFAULT on JSchemaChangeitem for postgresql
Testing Instructions
With latest staging on postgresql go to Manage > Database.
Expected result
no notice
Actual result
Notice: Undefined offset:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Postgresql SQL Administration com_admin |
IMO this is the wrong solution. We can not remove DROP DEFAULT from update files.
We have to fix php code in https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/schema/changeitem/postgresql.php#L132
I suppose that reverse the order of elseif
with
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/schema/changeitem/postgresql.php#L111
would solve the problem.
could be i've checked rather quickly,
but why
We can not remove DROP DEFAULT from update files.
- because drop default - in general this is not a solution but only temporary fix, we do not want to remove all "DROP DEFAULT ..." from sql updates files.
- because other databases does not have default too
- because bug is in the file mentioned by me earlier, not in sql updates files.
i've just looked at #__contact_details and
ALTER TABLE "#__contact_details" ALTER COLUMN "name" DROP DEFAULT;
even if for me is not needed (DROP DEFAULT) , i agree with you should be correctly managed by changeitem for postgresql
| Labels |
Added:
?
|
||
| Category | Postgresql SQL Administration com_admin | ⇒ | Postgresql SQL Administration com_admin Libraries |
| Category | Postgresql SQL Administration com_admin Libraries | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14423.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-02 19:41:32 |
| Closed_By | ⇒ | alikon |
I have tested this item✅ successfully on 2e35e03
Thanks alikon!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14423.