[#14240] - [4.0][RFC] Serialise inline scripts and inline styles
- Closed
- 9 Mar 2019
- Medium
- Build: 4.0-dev
- # 14240
- Diff
- dgrammatiko:serialise_tags
- Failure continuous-integration/drone/pr the build failed Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Failure continuous-integration/appveyor/pr AppVeyor was unable to build non-mergeable pull request Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Drop the separate arrays for inline scripts and styles
- The data will be merged in the relative scrips and styleSheets arrays (can we remove the underscore???)
- Make
JHTMLcompatible with these changes
Testing Instructions
Apply patch and observe the produced head, inline scripts should be between script tags with src, same for the styles
Also the jQuery.noConflict(); should be inline and not a file...
Update to JHtml
for inline script:
JHtml::_('script', '', ['inline' => ‘content for inline script’]);For inline style:
JHtml::_('stylesheet', '', ['inline' => ‘content for inline script’]);Actual result
Check the structure of the head:
Documentation Changes Required
YUP!
dgt41
- | Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Libraries JavaScript |
Two simple examples to point out how the system fails badly with its current architecture:
CSS
com_something, loads:
- bootstrap.css:
.btn { background-color: white;} - inline css:
.btn { background-color: black;}
mod_something loads mod.css with.btn { background-color: red;}
Expected colour red, actual black
JS
com_something, loads:
- core.js Joomla.SubmitForm = function1
- inline script Joomla.SubmitForm = function2
mod_something loads mod.js with Joomla.SubmitForm = function3
Expected function3, actual function2
Both Css and JS need to be appended in the order they had been inserted... :)
I guess this won't go anywhere, closing
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-13 12:10:31 |
| Closed_By | ⇒ | dgt41 |
| Status | Closed | ⇒ | New |
| Closed_Date | 2017-03-13 12:10:31 | ⇒ | |
| Closed_By | dgt41 | ⇒ |
| Status | New | ⇒ | Pending |
Closing, obviously Joomla 4 will be out of sync with the current Javascript and as people keep telling me I shouldn't run after unicorns (in this case js modules)...
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-09 21:00:30 |
| Closed_By | ⇒ | dgrammatiko |
Ok so what's the advantage of this? Like if I was building JDocument from scratch i would probably do something like this. But I don't see the advantage of changing the ordering that inline scripts/styles and files get loaded given how long it's been this way at this point