? ? ? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
24 Feb 2017

Summary of Changes

Adds a help button on the back end views of com_fields. They are static names, was unsure if a similar logic as with com_categories should be implemented.

Ping @infograf768. Are the language strings correct?

Testing Instructions

  • In the back end go to Content -> Fields
  • Click on the Help button
    image

Expected result

A help screen opens.

Actual result

No button

avatar laoneo laoneo - open - 24 Feb 2017
avatar laoneo laoneo - change - 24 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2017
Category Administration com_fields Language & Strings
avatar laoneo laoneo - change - 24 Feb 2017
The description was changed
avatar laoneo laoneo - edited - 24 Feb 2017
avatar Sandra97
Sandra97 - comment - 24 Feb 2017

Thaks Alon!
As it's a component, maybe better to name them JHELP_COMPONENT_FIELDS...
I'll create the Help Screens once we're sure for the names.

avatar tuts-22
tuts-22 - comment - 25 Feb 2017

The Help button but on clicking on it I get the following error!!!!!screen shot 2017-02-25 at 14 54 42


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14239.

avatar zero-24
zero-24 - comment - 25 Feb 2017

@tuts-22 yes this is expected as we need to fix the strigns to JHELP_COMPONENT_FIELDS:.. and as well create the pages to the docs if that is done the page links should work ?

avatar tuts-22
tuts-22 - comment - 25 Feb 2017

@zero-24 oh..Thanks for the information!!!Then should i mark the test as successful?

avatar Sandra97
Sandra97 - comment - 25 Feb 2017

Maybe better to not mark it as successful right now, as we need to be sure that the names of the language strings are the right ones.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Feb 2017

should that Issue @tuts-22 wrote be solved by joomla/joomla-websites#852?

avatar mbabker
mbabker - comment - 25 Feb 2017

Nope. It doesn't address a page not found issue, he only created a namespace alias for the Help37 namespace to load Help36 until 3.7 releases.

https://docs.joomla.org/Help36:Fields_fields doesn't exist.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 25 Feb 2017

thanks for Info, @mbabker

avatar laoneo
laoneo - comment - 6 Mar 2017

So how do we proceeded here, any maintainer a suggestion?

avatar mbabker
mbabker - comment - 6 Mar 2017

You also need strings in https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.com_admin.ini so the pages show up in the sidebar of administrator/index.php?option=com_admin&view=help. I wrote https://github.com/joomla/joomla-cms/blob/staging/build/helpTOC.php once upon a time to help make sure that side bar and the static file it is built from stays in sync with the help screen category on the docs wiki but I honestly have no clue what state is in anymore.

As for the JHELP keys, I'd suggest following the naming structure from com_contact for the new strings:

JHELP_COMPONENTS_CONTACT_CATEGORIES="Components_Contacts_Categories"
JHELP_COMPONENTS_CONTACT_CATEGORY_EDIT="Components_Contacts_Categories_Edit"
JHELP_COMPONENTS_CONTACTS_CONTACTS_EDIT="Components_Contacts_Contacts_Edit"
JHELP_COMPONENTS_CONTACTS_CONTACTS="Components_Contacts_Contacts"

Beyond that, seems fine to me.

avatar Sandra97
Sandra97 - comment - 6 Mar 2017

I've created the 4 help screens following Allon's keys. But we can still rename them of course.
If we add JHelp Keys for com_contact, I presume we shoud also have JHelp keys for com_contentand com_users?
Thank you to make my life miserable Michael ;)

avatar mbabker
mbabker - comment - 6 Mar 2017

You don't need separate keys for each fields context, I'm just suggesting to use the same naming structure so it's consistent is all. It doesn't matter at this point if it's changed or not though.

The COM_ADMIN_HELP keys are definitely needed though as I said for the navigation on that one page.

avatar laoneo laoneo - change - 7 Mar 2017
Labels Added: ? ?
avatar laoneo
laoneo - comment - 7 Mar 2017

Added COMPONENTS to the keys and made it available in the help page

image

Guess not it should be ok.

avatar infograf768
infograf768 - comment - 7 Mar 2017

New strings need to be alpha ordered. Thanks.

avatar laoneo
laoneo - comment - 7 Mar 2017

I never learn that, thanks @infograf768 for the hint. Fixed.

avatar laoneo
laoneo - comment - 8 Mar 2017

Should we go with the current set up, then I would say it is ready for testing>?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Mar 2017

@laoneo is it a Question or a go for testing?

avatar laoneo
laoneo - comment - 8 Mar 2017

It's more of a question for @infograf768, @Sandra97 and @mbabker.

avatar Sandra97
Sandra97 - comment - 8 Mar 2017

3 of the 4 help screens are set up and should work well.
For the 4th one (Components Fields Fields), I did a mistake while renaming it. Tom will fix it, but it's not yet done.

avatar laoneo
laoneo - comment - 8 Mar 2017

Very good, so I guess it's up to @infograf768 and @mbabker to give a go for the help keys and then it is ready for testing I would say.

avatar Sandra97
Sandra97 - comment - 8 Mar 2017

Tom has fixed the 4th help screen. So everything is ready on JDocs.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 8 Mar 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 8 Mar 2017

I have tested this item ? unsuccessfully on 615ff6f

Test on Article - Fields:


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14239.

avatar Sandra97
Sandra97 - comment - 8 Mar 2017

@laoneo, Regarding these lines:

index

Shouldn't it be Components_Fields...instead of Fields_...?

avatar laoneo
laoneo - comment - 9 Mar 2017

@Sandra97 done.

avatar Sandra97
Sandra97 - comment - 9 Mar 2017

Thank you Allon!

avatar infograf768 infograf768 - test_item - 10 Mar 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 10 Mar 2017

I have tested this item successfully on fb762a7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14239.

avatar infograf768
infograf768 - comment - 10 Mar 2017

@Sandra97
Looking at this, I saw no specific help is set for multilang associations component although the help button is present with JToolbarHelper::help('JGLOBAL_HELP');
Can you take care of that?

avatar Sandra97
Sandra97 - comment - 10 Mar 2017

Thanks @infograf768
I will create them and let you know when done.

avatar Sandra97 Sandra97 - test_item - 10 Mar 2017 - Tested successfully
avatar Sandra97
Sandra97 - comment - 10 Mar 2017

I have tested this item successfully on fb762a7

Followed the instructions, all Help Screens are working as expected, in articles, users as well as contacts.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14239.

avatar laoneo
laoneo - comment - 11 Mar 2017

Ready for RTC?

avatar zero-24 zero-24 - change - 11 Mar 2017
Milestone Added:
Status Pending Ready to Commit
Labels Added: ?
avatar rdeutz rdeutz - change - 12 Mar 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-03-12 16:28:17
Closed_By rdeutz
Labels
avatar rdeutz rdeutz - close - 12 Mar 2017
avatar rdeutz rdeutz - merge - 12 Mar 2017

Add a Comment

Login with GitHub to post a comment