User tests: Successful: Unsuccessful:
Adds a help button on the back end views of com_fields. They are static names, was unsure if a similar logic as with com_categories should be implemented.
Ping @infograf768. Are the language strings correct?
A help screen opens.
No button
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_fields Language & Strings |
The Help button but on clicking on it I get the following error!!!!!
Maybe better to not mark it as successful right now, as we need to be sure that the names of the language strings are the right ones.
should that Issue @tuts-22 wrote be solved by joomla/joomla-websites#852?
Nope. It doesn't address a page not found issue, he only created a namespace alias for the Help37 namespace to load Help36 until 3.7 releases.
https://docs.joomla.org/Help36:Fields_fields doesn't exist.
So how do we proceeded here, any maintainer a suggestion?
You also need strings in https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.com_admin.ini so the pages show up in the sidebar of administrator/index.php?option=com_admin&view=help
. I wrote https://github.com/joomla/joomla-cms/blob/staging/build/helpTOC.php once upon a time to help make sure that side bar and the static file it is built from stays in sync with the help screen category on the docs wiki but I honestly have no clue what state is in anymore.
As for the JHELP
keys, I'd suggest following the naming structure from com_contact
for the new strings:
JHELP_COMPONENTS_CONTACT_CATEGORIES="Components_Contacts_Categories"
JHELP_COMPONENTS_CONTACT_CATEGORY_EDIT="Components_Contacts_Categories_Edit"
JHELP_COMPONENTS_CONTACTS_CONTACTS_EDIT="Components_Contacts_Contacts_Edit"
JHELP_COMPONENTS_CONTACTS_CONTACTS="Components_Contacts_Contacts"
Beyond that, seems fine to me.
I've created the 4 help screens following Allon's keys. But we can still rename them of course.
If we add JHelp Keys for com_contact
, I presume we shoud also have JHelp keys for com_content
and com_users
?
Thank you to make my life miserable Michael ;)
You don't need separate keys for each fields context, I'm just suggesting to use the same naming structure so it's consistent is all. It doesn't matter at this point if it's changed or not though.
The COM_ADMIN_HELP
keys are definitely needed though as I said for the navigation on that one page.
Labels |
Added:
?
?
|
New strings need to be alpha ordered. Thanks.
I never learn that, thanks @infograf768 for the hint. Fixed.
Should we go with the current set up, then I would say it is ready for testing>?
It's more of a question for @infograf768, @Sandra97 and @mbabker.
3 of the 4 help screens are set up and should work well.
For the 4th one (Components Fields Fields), I did a mistake while renaming it. Tom will fix it, but it's not yet done.
Very good, so I guess it's up to @infograf768 and @mbabker to give a go for the help keys and then it is ready for testing I would say.
Tom has fixed the 4th help screen. So everything is ready on JDocs.
I have tested this item
Test on Article - Fields:
Thank you Allon!
I have tested this item
Thanks @infograf768
I will create them and let you know when done.
I have tested this item
Followed the instructions, all Help Screens are working as expected, in articles, users as well as contacts.
Ready for RTC?
Milestone |
Added: |
||
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-12 16:28:17 |
Closed_By | ⇒ | rdeutz | |
Labels |
Thaks Alon!
As it's a component, maybe better to name them JHELP_COMPONENT_FIELDS...
I'll create the Help Screens once we're sure for the names.