? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
24 Feb 2017

Pull Request for Issue #14222.

Summary of Changes

Properly check published state of tag and check against view levels

Testing Instructions

  • Assign a tag to an article.
  • Visit the article in frontend and click on the tag so you get tot he tag view. Make sure you're not logged in with a user.
  • Unpublish the tag in backend.
  • Reload the tag view -> Should create an error but instead still shows fine.
  • Publish the tag again and change the access level to "Registered".
  • Reload the tag view again -> Should create an error but instead still shows fine.

Expected result

Both reloads should create an error since we don't have access to that tag.

Actual result

View shows fine, ignoring access and published state.

Documentation Changes Required

None

Disclaimer

Given which component we are talking about, I fully expect additional related issues. This PR doesn't try to solve everything ?

avatar Bakual Bakual - open - 24 Feb 2017
avatar Bakual Bakual - change - 24 Feb 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2017
Category com_tags Front End
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 24 Feb 2017

I have tested this item successfully on ed4f37a

Both Cases works with PR as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14227.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 24 Feb 2017 - Tested successfully
avatar zero-24
zero-24 - comment - 25 Feb 2017

I have tested this item successfully on ed4f37a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14227.

avatar zero-24 zero-24 - test_item - 25 Feb 2017 - Tested successfully
avatar zero-24 zero-24 - change - 25 Feb 2017
Milestone Added:
Status Pending Ready to Commit
Labels Added: ? ?
avatar rdeutz rdeutz - change - 26 Feb 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-02-26 13:05:09
Closed_By rdeutz
Labels
avatar rdeutz rdeutz - close - 26 Feb 2017
avatar rdeutz rdeutz - merge - 26 Feb 2017

Add a Comment

Login with GitHub to post a comment